Do not use clear_store! during precompilation
#136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
approved these changes
Apr 1, 2025
|
Tests need JuliaDebug/TerminalRegressionTests.jl#18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by JuliaLang/julia#57635, if in the future this issue is resolved in a way that allows for evaluation into closed modules during precompilation then we may revert this PR as well as #134.
#134 was not sufficient (see #134 (comment)) because
Infiltrator.__init__()may still be called during precompilation by any package that loads Infiltrator, and this function mutates the store.I further added a safeguard during access to
getfield(::Session, :store)to make sure we correctly report any errors due to this new behavior.