Add depth-limited stacktraces, fix Julia 1.1 compatibility #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hasfield` was introduced in Julia 1.2, so commit `b4ed757` inadvertetly broke compatibility with version of between 1.1 and 1.2. This commit skips the check for Julia < 1.2.
Sbozzolo
force-pushed
the
master
branch
2 times, most recently
from
52e6d5e to
61c9b4a
Compare
|
Tests will be fixed by JuliaDebug/TerminalRegressionTests.jl#18. |
pfitzseb
reviewed
Apr 1, 2025
src/Infiltrator.jl
Outdated
Comment on lines
430
to
431
| - `@trace`: Print the current stack trace. | ||
| - `@limited_trace`: Print the current stack trace with reduced type information. (Only for Julia >= 1.10) |
There was a problem hiding this comment.
I think we should make the reduced info the default and add @trace_all if someone wants to print complete type info. Thoughts?
There was a problem hiding this comment.
I agree, (that's how I would have done it, but I didn't want to change the existing behavior).
I'll update the PR with this
There was a problem hiding this comment.
I applied the changes and successfully regenerated and re-run the tests.
With this commit, Infiltrator now takes advantage the type-limited stacktrace printing infrastructure introduced in Julia 1.10. As a result, Infiltrator now compresses type information, greatly enhancing readability. A new option, `@trace_all`, is added to print the full type information.
pfitzseb
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I work with deep types and full stack traces are unmanagable.
This PR adds a new option
@limited_traceto print stack traces with reduced type information, as shown in the screenshot below. This uses the same infrastructure introduced in Julia 1.10 to reduce verbosity of traces in REPL.In this, I tried re-generating and re-running the tests. I found that support for Julia 1.1 is broken (because
hasfieldwas introduced in Julia 1.2).