Skip to content

refactor!: split out preparation #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 2, 2025
Merged

refactor!: split out preparation #179

merged 12 commits into from
Jul 2, 2025

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jun 15, 2025

Warning

Breaking changes.

Breaking changes

  • Split out preparation into a function prepare_implicit to simplify ImplicitFunction (not yet documented)
  • Modify linear_solver specification
    • modify IterativeLinearSolver, remove IterativeSolvers dependency
    • replace \ with DirectLinearSolver
  • Remove keep_input_type from OperatorRepresentation

Non-breaking changes

  • Replace block solver with individual solver in ForwardDiff

Still to do

  • Document preparation
  • Warn against nesting
  • Decide if the prepared chain rules are valid since there is mutation

Copy link

codecov bot commented Jun 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
ext/ImplicitDifferentiationChainRulesCoreExt.jl 95.23% <100.00%> (+0.23%) ⬆️
ext/ImplicitDifferentiationForwardDiffExt.jl 100.00% <100.00%> (ø)
src/ImplicitDifferentiation.jl 100.00% <ø> (ø)
src/callable.jl 100.00% <100.00%> (ø)
src/execution.jl 96.26% <100.00%> (-3.74%) ⬇️
src/implicit_function.jl 100.00% <100.00%> (+11.53%) ⬆️
src/preparation.jl 100.00% <100.00%> (ø)
src/settings.jl 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle changed the title refactor!: move to in-place linear solve, remove IterativeLinearSolvers refactor!: split out preparation Jul 1, 2025
@gdalle gdalle marked this pull request as ready for review July 2, 2025 04:38
@gdalle gdalle merged commit bc7267a into main Jul 2, 2025
4 checks passed
@gdalle gdalle deleted the gd/workspace branch July 2, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant