fix floating point #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a repost of my PR on LightGraphsFlows.jl.
Closes #28.
is_zero
is necessary because when comparing against zero, this is equivalent to strict equality (only absolute difference is tolerated).eps
is not defined for Integers so we need to separateAbstractFloat
fromInteger
.From last PR, I re-coded the
is_zero
function to take advantage of multiple dispatch, and added a non regression test.As we only add errors, should I use
nv(g)*eps(T)
instead ofsqrt(eps(T))
?