Skip to content

Fix LU deprecation and improve type-stability of MatrixWorkspace #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 3, 2024

Conversation

ChrisRackauckas
Copy link
Contributor

Fixes LoadError: LU{T, S}(factors::AbstractMatrix{T}, ipiv::AbstractVector{<:Integer}, info::BlasInt) where {T, S} is deprecated, use LU{T, S, typeof(ipiv)}(factors, ipiv, info) instead.` deprecation, and adds missing type parameters on lu and qr in the matrix workspace.

Fixes LoadError: `LU{T, S}(factors::AbstractMatrix{T}, ipiv::AbstractVector{<:Integer}, info::BlasInt) where {T, S}` is deprecated, use `LU{T, S, typeof(ipiv)}(factors, ipiv, info)` instead.` deprecation, and adds missing type parameters on lu and qr in the matrix workspace.
@ChrisRackauckas
Copy link
Contributor Author

ChrisRackauckas commented Aug 2, 2024

@oscardssmith can you help figure out what that QR error is?

@ChrisRackauckas
Copy link
Contributor Author


julia> typeof(qr(rand(ComplexF64,5,5)))
LinearAlgebra.QRCompactWY{ComplexF64, Matrix{ComplexF64}, Matrix{ComplexF64}}

@oscardssmith
Copy link
Contributor

QR and QRCompactWY are different types with different type parameters.

Co-authored-by: Oscar Smith <oscardssmith@gmail.com>
@PBrdng
Copy link
Collaborator

PBrdng commented Aug 3, 2024

Can you run JuliaFormatter on the changed files?

@ChrisRackauckas
Copy link
Contributor Author

I did but it seemed to change everything, so I'm not sure what version of the formatter you're using.

@PBrdng
Copy link
Collaborator

PBrdng commented Aug 3, 2024

I used v1.0.56. It's fine if the formatter changes everything in those three files, as long as the format is consistent.

But I can also update the format later this week.

@ChrisRackauckas
Copy link
Contributor Author

It changes all files, because none of them match the format.

@PBrdng
Copy link
Collaborator

PBrdng commented Aug 3, 2024

Weird. Ok, let me run the formatter.

@PBrdng PBrdng merged commit 6255626 into JuliaHomotopyContinuation:main Aug 3, 2024
3 of 4 checks passed
@PBrdng PBrdng mentioned this pull request Aug 3, 2024
@PBrdng
Copy link
Collaborator

PBrdng commented Aug 3, 2024

See #583

@isaacsas
Copy link

isaacsas commented Aug 5, 2024

@PBrdng is it possible to make a bug fix release with this PR? We are having some CI errors in Catalyst due to this. Thanks!

@PBrdng
Copy link
Collaborator

PBrdng commented Aug 6, 2024

Yes, sorry, I just initiated a release with this bug fix.

@PBrdng
Copy link
Collaborator

PBrdng commented Aug 6, 2024

@isaacsas @ChrisRackauckas: I didn't notice it before, but is there a reason the Julia version in Project.toml has been changed from 1.8 to 1.10? This is preventing a patch release.

@ChrisRackauckas ChrisRackauckas deleted the patch-2 branch August 6, 2024 06:11
@ChrisRackauckas
Copy link
Contributor Author

LU's type parameters had changed.

@PBrdng
Copy link
Collaborator

PBrdng commented Aug 6, 2024

Ok thanks. I will initiate another release later today.

@PBrdng
Copy link
Collaborator

PBrdng commented Aug 6, 2024

@isaacsas v2.10.0 should be available now.

@isaacsas
Copy link

isaacsas commented Aug 6, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants