-
Notifications
You must be signed in to change notification settings - Fork 32
Fix LU deprecation and improve type-stability of MatrixWorkspace #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LU deprecation and improve type-stability of MatrixWorkspace #580
Conversation
Fixes LoadError: `LU{T, S}(factors::AbstractMatrix{T}, ipiv::AbstractVector{<:Integer}, info::BlasInt) where {T, S}` is deprecated, use `LU{T, S, typeof(ipiv)}(factors, ipiv, info)` instead.` deprecation, and adds missing type parameters on lu and qr in the matrix workspace.
@oscardssmith can you help figure out what that QR error is? |
|
|
Co-authored-by: Oscar Smith <oscardssmith@gmail.com>
Can you run JuliaFormatter on the changed files? |
I did but it seemed to change everything, so I'm not sure what version of the formatter you're using. |
I used v1.0.56. It's fine if the formatter changes everything in those three files, as long as the format is consistent. But I can also update the format later this week. |
It changes all files, because none of them match the format. |
Weird. Ok, let me run the formatter. |
See #583 |
@PBrdng is it possible to make a bug fix release with this PR? We are having some CI errors in Catalyst due to this. Thanks! |
Yes, sorry, I just initiated a release with this bug fix. |
@isaacsas @ChrisRackauckas: I didn't notice it before, but is there a reason the Julia version in Project.toml has been changed from 1.8 to 1.10? This is preventing a patch release. |
LU's type parameters had changed. |
Ok thanks. I will initiate another release later today. |
@isaacsas v2.10.0 should be available now. |
Thanks! |
Fixes LoadError:
LU{T, S}(factors::AbstractMatrix{T}, ipiv::AbstractVector{<:Integer}, info::BlasInt) where {T, S}
is deprecated, useLU{T, S, typeof(ipiv)}(factors, ipiv, info)
instead.` deprecation, and adds missing type parameters on lu and qr in the matrix workspace.