Skip to content

fix LangevinSplitting #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

fix LangevinSplitting #203

merged 2 commits into from
Jun 26, 2025

Conversation

noeblassel
Copy link
Contributor

Fixes a bug in Langevin Splitting. For certain splittings (such as "BAOAB"), the first "B" step will not recompute forces for the sake of efficiency. Before this PR, the forces were initialized via asimilar call, which may result in NaNs propagating during the integration steps.

The PR fixes this by precomputing the forces once before the integration takes place.

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (7b1f972) to head (05766b2).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   67.41%   67.69%   +0.27%     
==========================================
  Files          37       38       +1     
  Lines        5678     5686       +8     
==========================================
+ Hits         3828     3849      +21     
+ Misses       1850     1837      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgreener64
Copy link
Collaborator

Thanks for spotting. Could you move it up to where forces_nounits_t is defined, like in NoseHoover?

I will make a release with this and any other fixes before the summer school.

@noeblassel
Copy link
Contributor Author

Thanks a lot. It's done.

@jgreener64 jgreener64 merged commit d489fc4 into JuliaMolSim:master Jun 26, 2025
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants