-
Notifications
You must be signed in to change notification settings - Fork 0
Examiner Agent #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examiner Agent #121
Conversation
Co-authored-by: Sarmisuper <stharm20@student.aau.dk>
Co-authored-by: Sarmisuper <stharm20@student.aau.dk>
- Add verdicts to player messages when in non-open-world - Make verdicts avaible to the Narrator through summary inclusion Co-authored-by: Sarmisuper <stharm20@student.aau.dk>
Co-authored-by: Sarmisuper <stharm20@student.aau.dk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
ChatRPG/API/ReActAgentChain.cs:101
- [nitpick] The constructor uses the parameter name 'reactPrompt' while storing it in a field named '_reActPrompt'. Consider standardizing the naming (e.g., use 'reactPrompt' or 'reActPrompt' consistently) for clarity and consistency.
_reActPrompt = reactPrompt ?? DefaultPrompt;
ChatRPG/API/Tools/UpdateGraphTool.cs:197
- [nitpick] Consider aligning the prompt label with other parts of the system by using a consistent descriptor (for example, 'Player input:' instead of 'Player:') in the string concatenation.
Replace(... + $"\nPlayer: {input}")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
ChatRPG/Services/ReActNarratorAgent.cs:213
- Review the logic change from checking 'campaign.NarrativeGraph != null' to '!campaign.IsOpenWorld' to ensure it accurately reflects the intended behavior for determining the campaign mode.
if (!campaign.IsOpenWorld)
ChatRPG/API/ReActAgentChain.cs:110
- [nitpick] Consider providing a meaningful default value for _actionPrompt if it is critical for agent behavior, rather than an empty string.
_actionPrompt = actionPrompt ?? string.Empty;
ChatRPG/Data/Migrations/ApplicationDbContextModelSnapshot.cs:168
- Verify that the one-to-one relationship between Message and Verdict is intended; if multiple messages should share a verdict, the unique index on VerdictId may need to be removed.
b.HasIndex("VerdictId").IsUnique();
Co-authored-by: Sarmisuper <stharm20@student.aau.dk>
Uh oh!
There was an error while loading. Please reload this page.