Skip to content

Conversation

KarmaKamikaze
Copy link
Owner

@KarmaKamikaze KarmaKamikaze commented Apr 7, 2025

  • Implemented Examiner Agent
  • Simplified ReAct Agent Chain by combining all constructors
  • Add verdicts to Narrator agent

Co-authored-by: Sarmisuper <stharm20@student.aau.dk>
@KarmaKamikaze KarmaKamikaze added the enhancement New feature or request label Apr 7, 2025
KarmaKamikaze and others added 4 commits April 8, 2025 13:34
Co-authored-by: Sarmisuper <stharm20@student.aau.dk>
- Add verdicts to player messages when in non-open-world
- Make verdicts avaible to the Narrator through summary inclusion

Co-authored-by: Sarmisuper <stharm20@student.aau.dk>
Co-authored-by: Sarmisuper <stharm20@student.aau.dk>
@KarmaKamikaze KarmaKamikaze requested a review from Copilot April 10, 2025 07:42
@KarmaKamikaze KarmaKamikaze marked this pull request as ready for review April 10, 2025 07:42
@Sarmisuper Sarmisuper requested review from Sarmisuper and removed request for Copilot April 10, 2025 07:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

ChatRPG/API/ReActAgentChain.cs:101

  • [nitpick] The constructor uses the parameter name 'reactPrompt' while storing it in a field named '_reActPrompt'. Consider standardizing the naming (e.g., use 'reactPrompt' or 'reActPrompt' consistently) for clarity and consistency.
_reActPrompt = reactPrompt ?? DefaultPrompt;

ChatRPG/API/Tools/UpdateGraphTool.cs:197

  • [nitpick] Consider aligning the prompt label with other parts of the system by using a consistent descriptor (for example, 'Player input:' instead of 'Player:') in the string concatenation.
Replace(... + $"\nPlayer: {input}")

@KarmaKamikaze KarmaKamikaze requested a review from Copilot April 10, 2025 07:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

ChatRPG/Services/ReActNarratorAgent.cs:213

  • Review the logic change from checking 'campaign.NarrativeGraph != null' to '!campaign.IsOpenWorld' to ensure it accurately reflects the intended behavior for determining the campaign mode.
if (!campaign.IsOpenWorld)

ChatRPG/API/ReActAgentChain.cs:110

  • [nitpick] Consider providing a meaningful default value for _actionPrompt if it is critical for agent behavior, rather than an empty string.
_actionPrompt = actionPrompt ?? string.Empty;

ChatRPG/Data/Migrations/ApplicationDbContextModelSnapshot.cs:168

  • Verify that the one-to-one relationship between Message and Verdict is intended; if multiple messages should share a verdict, the unique index on VerdictId may need to be removed.
b.HasIndex("VerdictId").IsUnique();

@KarmaKamikaze KarmaKamikaze merged commit 83c030b into dev Apr 10, 2025
14 checks passed
@KarmaKamikaze KarmaKamikaze deleted the feature/examiner_agent branch April 10, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants