Skip to content

Error logging params fix #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

Error logging params fix #3

merged 1 commit into from
Mar 3, 2025

Conversation

argent-smith
Copy link
Contributor

@argent-smith argent-smith commented Feb 28, 2025 •
edited
Loading

Fixed Logger#log_error call to conform to Ruby v3 syntax

Context

  • Internal error logging fails with "ArgumentError wrong number of arguments (given 2, expected 1)" error

What's inside

  • Fixed arguments to Logger#log_error call in Sbmt::Outbox::ErrorTracker::error

@bibendi
Copy link
Member

bibendi commented Mar 3, 2025

Thank you! Can you also update the changelog?

@bibendi bibendi added the bug Something isn't working label Mar 3, 2025
@argent-smith
Error logging params fix
b41fbb9 
Fixed Logger#log_error call to conform to Ruby v3 syntax
@argent-smith
Copy link
Contributor Author

Thank you! Can you also update the changelog?

done

@bibendi bibendi merged commit 3d75c0f into Kuper-Tech:master Mar 3, 2025
6 checks passed
@argent-smith argent-smith deleted the logger-params-fix branch March 3, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bibendi bibendi bibendi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@argent-smith @bibendi