-
Notifications
You must be signed in to change notification settings - Fork 36
[WIP] Mpi-Pingpong Benchmark #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaelmckinsey1
wants to merge
57
commits into
develop
Choose a base branch
from
benchmark/mpi-pingpong
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmckinsey1
commented
Apr 8, 2025
Running trials in the same allocation parameter (ramble) https://ramble.readthedocs.io/en/latest/workspace_config.html#experiment-repeats |
michaelmckinsey1
commented
May 2, 2025
…to benchmark/mpi-pingpong
This reverts commit 6bce99d.
f3335cb
to
dbeae11
Compare
dbeae11
to
dbb09cb
Compare
…to benchmark/mpi-pingpong
… Additionally disable limitation of max 1000 nodes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #726 +/- ##
========================================
Coverage 65.08% 65.08%
========================================
Files 44 44
Lines 3148 3148
Branches 237 237
========================================
Hits 2049 2049
Misses 1092 1092
Partials 7 7
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
application
docs
Improvements or additions to documentation
experiment
New or modified experiment
feature
New feature or request
system
New or modified system config
WIP
A work-in-progress not yet ready to commit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add MPI pingpong benchmark to benchpark.
Figure out how to pass location of pingpong directory (since private repo) on command line, instead of hard codingWaiting for repo to be public so we can change the url to point at public repoSet number of nodes instead of setting total ranks per machine
Set required variables for benchpark analyze
benchpark/experiments/kripke/experiment.py
Lines 141 to 145 in 95b4534
Depends on Use different value for placeholder instead of relying on max value #957
Adding/modifying a system (docs: Adding a System)
llnl-*/system.py
withsys_sockets_per_node
parameterAdding/modifying a benchmark (docs: Adding a Benchmark)
mpi-pingpong
benchmark