Skip to content

Conversation

michaelmckinsey1
Copy link
Collaborator

Description

  • DAFFINITY_GPU_BACKEND is now required to build affinity.rocm or affinity.cuda

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • Update repo/affinity/package.py

@michaelmckinsey1 michaelmckinsey1 self-assigned this Aug 25, 2025
@michaelmckinsey1 michaelmckinsey1 added bug Something isn't working ready for review Ready for review labels Aug 25, 2025
@michaelmckinsey1 michaelmckinsey1 added WIP A work-in-progress not yet ready to commit and removed ready for review Ready for review labels Aug 25, 2025
@michaelmckinsey1 michaelmckinsey1 added ready for review Ready for review and removed WIP A work-in-progress not yet ready to commit labels Aug 25, 2025
@github-actions github-actions bot added the feature New feature or request label Aug 25, 2025
pearce8
pearce8 previously approved these changes Aug 25, 2025
@pearce8
Copy link
Collaborator

pearce8 commented Aug 25, 2025

@michaelmckinsey1 please fix the lint error.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.08%. Comparing base (71bc83b) to head (e334873).

Files with missing lines Patch % Lines
lib/benchpark/experiment.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #994       +/-   ##
============================================
+ Coverage    49.81%   65.08%   +15.27%     
============================================
  Files           25       44       +19     
  Lines         1634     3148     +1514     
  Branches       237      237               
============================================
+ Hits           814     2049     +1235     
- Misses         770     1092      +322     
+ Partials        50        7       -43     
Files with missing lines Coverage Δ
lib/benchpark/experiment.py 88.08% <0.00%> (+41.87%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pearce8 pearce8 merged commit ce6a7af into develop Aug 26, 2025
58 checks passed
@pearce8 pearce8 deleted the michaelmckinsey1-patch-1 branch August 26, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application bug Something isn't working feature New feature or request ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants