fix: prevent show add signers early #5323
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, some buttons are displayed **too early** when opening the sidebar in the Files app. These buttons only make sense after all the necessary data has been loaded from the LibreSign API. A few seconds later, once the API response arrives, the application can correctly determine whether the buttons should be displayed or not. The problem: * Buttons appear before the API response. * This causes users to see options that should not be available yet. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
AntDavidLima
approved these changes
Aug 19, 2025
|
/backport to stable31 |
|
/backport to stable30 |
This was referenced Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Currently, some buttons are displayed too early when opening the sidebar in the Files app.
These buttons only make sense after all the necessary data has been loaded from the LibreSign API.
A few seconds later, once the API response arrives, the application can correctly determine whether the buttons should be displayed or not.
Problem
Screenshots
Before fix (buttons are shown even before the API returns data):
After fix (buttons are hidden until the API response is ready):
Pull Request Type
Pull request checklist