-
-
Notifications
You must be signed in to change notification settings - Fork 90
chore: remove unecessary check if node exists #5327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vitormattos
merged 20 commits into
main
from
chore/remove-unecessary-check-if-node-exists
Aug 20, 2025
Merged
chore: remove unecessary check if node exists #5327
vitormattos
merged 20 commits into
main
from
chore/remove-unecessary-check-if-node-exists
Aug 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2025
Closed
cdda566
to
0e8f7d9
Compare
AntDavidLima
requested changes
Aug 19, 2025
The broke tests aren't about LibreSign, already was fixed at guests app. {
"app": "PHP",
"message": "Declaration of OCA\\Guests\\AppConfigOverwrite::getValue(string $app, string $key, ?string $default = null): string must be compatible with OC\\AppConfig::getValue($app, $key, $default = '') at \/var\/www\/html\/apps-extra\/guests\/lib\/AppConfigOverwrite.php#22"
} |
Was removed unnecessary code. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
The method newFile already check if the file exists and work as expected when exists. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
The method get already do this and throw an exception when the file don't exists. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
The newFolder already do this Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
4da8f20
to
7a4f366
Compare
Fixed, was created a new release with the fix at app Guests and I made a rebase at this branch to be possible restart the CI. After your last review I only made this commit: |
AntDavidLima
approved these changes
Aug 20, 2025
#5327 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
/backport to stable31 |
/backport to stable30 |
backportbot-libresign bot
pushed a commit
that referenced
this pull request
Aug 20, 2025
#5327 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
backportbot-libresign bot
pushed a commit
that referenced
this pull request
Aug 20, 2025
#5327 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The method get already do this and throw an exception when the file don't exists.
Was possible remove all
nodeExists
.I also made small refactors after remove all
nodeExists
.Related Issue
Close #5321
Pull Request Type
Pull request checklist