Skip to content

Conversation

vitormattos
Copy link
Member

@vitormattos vitormattos commented Aug 16, 2025

Pull Request Description

The method get already do this and throw an exception when the file don't exists.

Was possible remove all nodeExists.

I also made small refactors after remove all nodeExists.

Related Issue

Close #5321

Pull Request Type

  • Refactoring (no functional changes, no api changes)

Pull request checklist

  • Did you explain or provide a way of how can we test your code ?
  • If your pull request is related to frontend modifications provide a print of before and after screen
  • Did you provide a general summary of your changes ?
  • Try to limit your pull request to one type, submit multiple pull requests if needed
  • I implemented tests that cover my contribution

@vitormattos vitormattos added this to the Next Major (32) milestone Aug 16, 2025
@vitormattos vitormattos self-assigned this Aug 16, 2025
@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Aug 16, 2025
@vitormattos vitormattos force-pushed the chore/remove-unecessary-check-if-node-exists branch from cdda566 to 0e8f7d9 Compare August 16, 2025 16:41
@vitormattos vitormattos marked this pull request as draft August 16, 2025 16:42
@vitormattos vitormattos marked this pull request as ready for review August 16, 2025 19:07
@github-project-automation github-project-automation bot moved this from 0. Needs triage to 1. to do in Roadmap Aug 19, 2025
@vitormattos
Copy link
Member Author

The broke tests aren't about LibreSign, already was fixed at guests app.

{
	"app": "PHP",
	"message": "Declaration of OCA\\Guests\\AppConfigOverwrite::getValue(string $app, string $key, ?string $default = null): string must be compatible with OC\\AppConfig::getValue($app, $key, $default = '') at \/var\/www\/html\/apps-extra\/guests\/lib\/AppConfigOverwrite.php#22"
}

Was removed unnecessary code.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
The method newFile already check if the file exists and work as expected
when exists.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
The method get already do this and throw an exception when the file
don't exists.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
The newFolder already do this

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos force-pushed the chore/remove-unecessary-check-if-node-exists branch from 4da8f20 to 7a4f366 Compare August 20, 2025 12:10
@vitormattos
Copy link
Member Author

The broke tests aren't about LibreSign, already was fixed at guests app.

{
	"app": "PHP",
	"message": "Declaration of OCA\\Guests\\AppConfigOverwrite::getValue(string $app, string $key, ?string $default = null): string must be compatible with OC\\AppConfig::getValue($app, $key, $default = '') at \/var\/www\/html\/apps-extra\/guests\/lib\/AppConfigOverwrite.php#22"
}

Fixed, was created a new release with the fix at app Guests and I made a rebase at this branch to be possible restart the CI.

After your last review I only made this commit:

7a4f366

#5327 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
Copy link
Member Author

/backport to stable31

@vitormattos
Copy link
Member Author

/backport to stable30

@vitormattos vitormattos merged commit f061db1 into main Aug 20, 2025
56 checks passed
@vitormattos vitormattos deleted the chore/remove-unecessary-check-if-node-exists branch August 20, 2025 17:44
@github-project-automation github-project-automation bot moved this from 1. to do to 4. to release in Roadmap Aug 20, 2025
backportbot-libresign bot pushed a commit that referenced this pull request Aug 20, 2025
#5327 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
backportbot-libresign bot pushed a commit that referenced this pull request Aug 20, 2025
#5327 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos removed this from the Next Major (32) milestone Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 4. to release
Development

Successfully merging this pull request may close these issues.

Reduce IO when create folder
2 participants