Skip to content

Extend #308 with -unwind support #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2025
Merged

Extend #308 with -unwind support #309

merged 2 commits into from
Mar 22, 2025

Conversation

chorman0773
Copy link
Contributor

Adding to #308, this adds C-unwind and system-unwind fn-ptr ZeroableInPod impls behind the zeroable_unwind_fn feature gate.

@Lokathor
Copy link
Owner

the 1.34 check didn't pass, is the cfg somehow not working?

@Lokathor Lokathor merged commit 46d0910 into Lokathor:main Mar 22, 2025
13 checks passed
@chorman0773
Copy link
Contributor Author

the 1.34 check didn't pass, is the cfg somehow not working?

Yep. Apparently extern tags get validated when parsing before Rust 1.41, instead of after macro/cfg expansion, so you can't even gate an extern tag on cfg in those versions (or use an attribute macro either, I'd assume).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver-patch semver patch change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chorman0773 @Lokathor