Skip to content

Add setConfig public api #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Add setConfig public api #141

merged 1 commit into from
Sep 10, 2024

Conversation

Ketho
Copy link
Contributor

@Ketho Ketho commented Aug 12, 2024

Following my question in LuaLS/lua-language-server#2794 I would like to have languageserver.setConfig as a public api, so that third party extensions can edit LuaLS configurations, in the same fashion as LuaLS plugins.

This should make it easier to edit configurations without having to deal with .luarc.json and settings.json.
I'm requesting @carsakiller to review this.

@carsakiller carsakiller added the enhancement New feature or request label Aug 13, 2024
@sumneko sumneko merged commit 167692d into LuaLS:master Sep 10, 2024
5 checks passed
@Ketho Ketho deleted the api branch September 12, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants