Skip to content

Revert old guessers and tables removal #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 25, 2024
Merged

Revert old guessers and tables removal #4752

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4b383ae
revert old guessers removal
IAlibay Oct 20, 2024
d2ee68f
Add tests back
IAlibay Oct 20, 2024
e791a00
Add tables back
IAlibay Oct 20, 2024
a4b884c
Black new file
IAlibay Oct 20, 2024
15d7f7d
Add deprecation warning for guessers
IAlibay Oct 24, 2024
032c513
Add test for tables deprecation
IAlibay Oct 24, 2024
051f22d
Add test for guessers deprecation
IAlibay Oct 24, 2024
578046d
Update changelog
IAlibay Oct 24, 2024
2dbbf8e
Merge branch 'develop' into revert-topology-guessers-removal
IAlibay Oct 24, 2024
be692af
Update package/MDAnalysis/topology/guessers.py
IAlibay Oct 24, 2024
ec92012
Add docs back and fix some review comments
IAlibay Oct 25, 2024
878aa5c
Add tables docs
IAlibay Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions package/CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ Changes
numpy.testing.assert_allclose #4438)

Deprecations
* MDAnalysis.topology.guessers is deprecated in favour of the neww
Guessers API and will be removed in version 3.0 (PR #4752)
* MDAnalysis.topology.tables is deprecated in favour of
MDAnalysis.guesser.tables and will be removed in version 3.0 (PR #4752)
* Element guessing in the ITPParser is deprecated and will be removed in version 3.0
(Issue #4698)
* Unknown masses are set to 0.0 for current version, this will be depracated
Expand Down
Loading
Loading