Skip to content

Conversation

ChiahsinChu
Copy link
Contributor

@ChiahsinChu ChiahsinChu commented Oct 29, 2024

Fixes #4775

Changes made in this Pull Request:

  • add precision for XYZWriter
  • UT for new feature

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4771.org.readthedocs.build/en/4771/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up from discord, could you please open up an issue to discuss what you are trying to achieve here please? The ASE import cannot happen unfortunately.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (557f27d) to head (2540e83).
Report is 45 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4771      +/-   ##
===========================================
+ Coverage    86.08%   86.41%   +0.33%     
===========================================
  Files          177      189      +12     
  Lines        21742    22809    +1067     
  Branches      3055     3055              
===========================================
+ Hits         18717    19711     +994     
- Misses        2593     2666      +73     
  Partials       432      432              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@orbeckst
Copy link
Member

@ChiahsinChu thank you for your contribution. Could you please open an issue that requests the feature that this PR is adding, namely "setting output precision for XYZ Writer"? Before commenting on the implementation in a PR we first need to decide if the requested feature should be added. In the issue provide support in favor of this feature, e.g., documentation for feature specification, description of need etc.

Thank you!

@orbeckst
Copy link
Member

I am asking for an issue because the issue #4772 that you linked does not seem to have anything to do with the content of this PR. Having separate issues for separate features is a good thing!

@ChiahsinChu ChiahsinChu changed the title New features for XYZWriter Allow use-defined precision in XYZWriter Oct 31, 2024
@orbeckst
Copy link
Member

@ChiahsinChu do you want to re-open this PR?

@ChiahsinChu ChiahsinChu reopened this Nov 20, 2024
@orbeckst orbeckst linked an issue Dec 4, 2024 that may be closed by this pull request
@orbeckst orbeckst requested a review from IAlibay December 4, 2024 00:09
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the PR looks sensible to me.

Can you please cleanup CHANGELOG — we released 2.9.0 a week ago so you have to merge develop into your branch and then add your change notes under 2.9.0, please.

@orbeckst orbeckst self-assigned this Dec 4, 2024
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just fix the small typo in CHANGELOG, otherwise looks good to me.

Thank you for your contribution!!

@orbeckst
Copy link
Member

orbeckst commented Dec 4, 2024

(The test failures are not due to your PR.)

Co-authored-by: Oliver Beckstein <orbeckst@gmail.com>
@RMeli
Copy link
Member

RMeli commented Dec 6, 2024

Thank you @ChiahsinChu. Only RDKit tests are failing, which is a known issue we are working on, and unrelated to this PR.

@RMeli RMeli enabled auto-merge (squash) December 6, 2024 21:58
@RMeli RMeli merged commit 83f702f into MDAnalysis:develop Dec 6, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow use-defined precision in XYZWriter
4 participants