Fix incorrect self.atom assignment in SingleFrameReaderBase #5055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5055 +/- ##
========================================
Coverage 93.62% 93.62%
========================================
Files 177 177
Lines 22001 22001
Branches 3114 3114
========================================
Hits 20599 20599
Misses 947 947
Partials 455 455 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
approved these changes
Jun 1, 2025
package/CHANGELOG
Outdated
| @@ -33,6 +33,7 @@ Fixes | |||
| * Fixes the benchmark `SimpleRmsBench` in `benchmarks/analysis/rms.py` | |||
| by changing the way weights for RMSD are calculated, instead of | |||
| directly passing them. (Issue #3520, PR #5006) | |||
| * Fix incorrect `self.atom` assignment in SingleFrameReaderBase (Issue #5052, PR #5055) | |||
There was a problem hiding this comment.
Sorry to be pedantic about this, but could you put this at the top? It's very useful on release to get the chronological order right.
|
@yuxuanzhuang please feel free to merge at your leisure once you update the changelog entry. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5052
Changes made in this Pull Request:
SingleFrameReaderBasewhereself.atomwas incorrectly used instead ofself.atomsto store the number of atomsDATAReaderof LAMPMPS of this upstream setting.PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5055.org.readthedocs.build/en/5055/