Skip to content

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Jul 29, 2025

Update the list of file to exclude from formatting based on the active PRs of the past month.

If this is too aggressive (maybe?), I can expand to more months.


📚 Documentation preview 📚: https://mdanalysis--5092.org.readthedocs.build/en/5092/

@RMeli RMeli changed the title [fmt] Format more files for package [fmt] Format more files in package Jul 29, 2025
@RMeli RMeli requested review from orbeckst and marinegor July 29, 2025 22:13
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 93.22034% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.85%. Comparing base (b4ab7e5) to head (92293eb).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
package/MDAnalysis/coordinates/H5MD.py 90.32% 6 Missing and 9 partials ⚠️
package/MDAnalysis/coordinates/GMS.py 76.00% 3 Missing and 3 partials ⚠️
package/MDAnalysis/coordinates/PDB.py 94.00% 5 Missing and 1 partial ⚠️
package/MDAnalysis/coordinates/XYZ.py 64.70% 4 Missing and 2 partials ⚠️
package/MDAnalysis/coordinates/chain.py 88.57% 3 Missing and 1 partial ⚠️
package/MDAnalysis/core/universe.py 96.29% 2 Missing and 1 partial ⚠️
package/MDAnalysis/coordinates/MOL2.py 92.85% 1 Missing ⚠️
package/MDAnalysis/coordinates/memory.py 96.87% 0 Missing and 1 partial ⚠️
package/MDAnalysis/core/selection.py 98.82% 1 Missing ⚠️
package/MDAnalysis/topology/base.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5092   +/-   ##
========================================
  Coverage    93.85%   93.85%           
========================================
  Files          178      178           
  Lines        22122    22122           
  Branches      3129     3129           
========================================
  Hits         20763    20763           
  Misses         902      902           
  Partials       457      457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(You can also include DCD.py if you like, I can deal with merge conflicts in PR #5071)

@RMeli
Copy link
Member Author

RMeli commented Jul 31, 2025

@orbeckst do you think a month is fine or too short?

@orbeckst
Copy link
Member

Activity in the last month sounds reasonable to me.

@RMeli RMeli marked this pull request as ready for review August 2, 2025 14:01
@RMeli RMeli merged commit 08394b2 into develop Aug 4, 2025
24 of 25 checks passed
aniketpati1121 added a commit to aniketpati1121/mdanalysis that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants