Skip to content

Added the Subring package #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: development
Choose a base branch
from
Open

Conversation

fragandi
Copy link
Contributor

Hi everyone, here is a small package with methods for handling subrings based on the ones available in SAGBI and in InvariantRing

@d-torrance d-torrance changed the base branch from master to development April 17, 2025 21:58
Copy link
Member

@d-torrance d-torrance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

In addition to the other comments, there's also a typo:

M2/Macaulay2/packages/Subring/SubringDoc.m2:282: accessable ==> accessible

@d-torrance
Copy link
Member

Also, "Subring" should be added to the =distributed-packages file.

@fragandi
Copy link
Contributor Author

Also, "Subring" should be added to the =distributed-packages file.

I could not find this file, can you give me more details on the path?

@d-torrance
Copy link
Member

It's at M2/Macaulay2/packages/=distributed-packages

@fragandi
Copy link
Contributor Author

Also, "Subring" should be added to the =distributed-packages file.

I could not find this file, can you give me more details on the path?

NWM I thought a file could not start with = but I guess that's ok!

@mahrud
Copy link
Member

mahrud commented May 25, 2025

@fragandi is the plan to eventually make SubalgebraBases depend on this package? Because currently the subring conflict makes them not usable at the same time.

@fragandi
Copy link
Contributor Author

fragandi commented Jun 2, 2025

I have talked to Ollie @ollieclarke8787 before this PR and the idea is indeed to have Subrings as part of the M2 packages and then have SubalgebrasBases call on it. Maybe Ollie you can look into this conflict? Or let me know if I messed up something in the PR.

@mahrud
Copy link
Member

mahrud commented Jun 2, 2025

The current failure was because you forgot AuxiliaryFiles => true in the package header. The packages are fine alone, just not usable at the same time right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants