-
Notifications
You must be signed in to change notification settings - Fork 257
Added the Subring package #3736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
In addition to the other comments, there's also a typo:
M2/Macaulay2/packages/Subring/SubringDoc.m2:282: accessable ==> accessible
Also, "Subring" should be added to the =distributed-packages file. |
I could not find this file, can you give me more details on the path? |
It's at |
NWM I thought a file could not start with = but I guess that's ok! |
@fragandi is the plan to eventually make SubalgebraBases depend on this package? Because currently the |
I have talked to Ollie @ollieclarke8787 before this PR and the idea is indeed to have Subrings as part of the M2 packages and then have SubalgebrasBases call on it. Maybe Ollie you can look into this conflict? Or let me know if I messed up something in the PR. |
The current failure was because you forgot |
Hi everyone, here is a small package with methods for handling subrings based on the ones available in SAGBI and in InvariantRing