-
Notifications
You must be signed in to change notification settings - Fork 257
CI: Add integration testing with the Python interface passagemath-macaulay2 #3827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
CI: Add integration testing with the Python interface passagemath-macaulay2 #3827
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
I see
Several questions:
Here are the lines relevant to M2:
|
The GH Actions workflow can be configured to push a Docker image with the completed build for inspection to ghcr.io. It is currently not configured that way. The GH Actions workflow can also be configured to create an Artifact with the complete build logs. It is currently not configured that way.
The Python package build is trivial, and the tests are very quick.
The remaining 35 minutes are spent on building prerequisites from source. |
Others may disagree and chime in here, but I'm not sure if this repository is the right place to run an action that includes building anything other than M2 from source. For me, two kinds of integration tests make sense:
For instance, Macaulay2 has a Python package and in each actions build we test that it works, but we don't build Python from source to do so. On another note, while it's your prerogative to do so, I don't think distributing a prebuilt copy of M2-binary in the
|
Well, this documentation that you quote describes the interface that has been part of Sage for 20 years. And this approach to integration has greatly limited its use in the past. |
I just imagined it, and nothing bad happened. Care to elaborate? |
With these comments, which problem are you trying to address? Are you just concerned about the running time of the build, or something different? |
Well, what if you did? Do you feel that it would invalidate the integration test, or would it just be more costly? |
Binary wheels are now available, shipping Macaulay2 1.25.06. https://pypi.org/project/passagemath-macaulay2/#files |
Some next steps, collaboration most welcome:
|
https://github.com/passagemath/ is my pip-installable modularized fork of SageMath.
Here I propose adding a CI for integration testing with passagemath-macaulay2.
See also: