Add cache_stan_model parameter to relevant functions and update docum… #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation Introduced a new parameter, cache_stan_model, to functions including sccomp_estimate, sccomp_replicate, simulate_data, and sccomp_remove_outliers. This parameter specifies the cache directory for compiled Stan models, ensuring version isolation. Updated documentation and tests to reflect these changes, ensuring proper functionality and default settings.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the cache_stan_model parameter to various sccomp functions to improve Stan model caching and version isolation. The parameter allows users to specify custom cache directories for compiled Stan models, with automatic appending of the sccomp version to prevent conflicts between package versions.
- Adds
cache_stan_modelparameter to core functions:sccomp_estimate,sccomp_replicate,simulate_data, andsccomp_remove_outliers - Updates the global cache directory variable to not include version information by default (version is added in
load_modelwhen needed) - Comprehensive test suite to verify parameter availability, default values, and caching functionality with version isolation
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-cache_stan_model.R | New test file validating cache_stan_model parameter functionality and version isolation |
| man/*.Rd | Documentation updates adding cache_stan_model parameter descriptions to function help pages |
| R/utilities.R | Modifies global cache directory variable to exclude version (moved to load_model function) |
| R/*.R | Adds cache_stan_model parameter to function signatures and passes it through to load_model calls |
| NAMESPACE | Exports the sccomp_stan_models_cache_dir variable |
|
|
||
| # Clean up | ||
| unlink(expected_cache_dir, recursive = TRUE) | ||
| }) |
There was a problem hiding this comment.
There's an extra space before the closing brace. Remove the trailing space for consistency.
Suggested change
| }) | |
| }) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…entation
Introduced a new parameter, cache_stan_model, to functions including sccomp_estimate, sccomp_replicate, simulate_data, and sccomp_remove_outliers. This parameter specifies the cache directory for compiled Stan models, ensuring version isolation. Updated documentation and tests to reflect these changes, ensuring proper functionality and default settings.