Improve error handling and clarity. Updated parameter handling to use… #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… quosures and enhanced the error message for inconsistent factor values across samples.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…and refining data processing steps. Added group_by and summarise imports, and improved handling of factor variables in check_sample_consistency_of_factors function.
…Added n_distinct and all_of to enhance data processing capabilities.
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling and parameter consistency in the check_sample_consistency_of_factors function. The changes focus on updating parameter handling to use quosures properly and providing more detailed error messages when factor values are inconsistent across samples.
- Updated parameter handling from enquo-based to sym-based for consistency with main methods
- Enhanced error message formatting to provide specific details about conflicting factor values
- Added new dplyr imports to support improved data processing logic
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| R/validation.R | Refactored check_sample_consistency_of_factors function with improved parameter handling and detailed error reporting |
| R/sccomp_estimate.R | Updated function call to pass string parameters instead of quosure expressions |
| NAMESPACE | Added imports for new dplyr functions used in the validation logic |
| DESCRIPTION | Version bump from 2.1.16 to 2.1.17 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… quosures and enhanced the error message for inconsistent factor values across samples.