Skip to content

Ditch GULP in favor of inhouse solution #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

greysilly7
Copy link
Contributor

Description

Switches to a in-house solution for ditching GULP, resulted in going from .5XXms to .0Xms

Related issues

Any related issues, delete if there are none

Signed-off-by: greysilly7 <greysilly7@gmail.com>
@MathMan05
Copy link
Owner

there's no way half of those scripts run correctly, some rely on things being installed globally, and why is the build split like that?

@MathMan05
Copy link
Owner

also you screwed up the description again

@greysilly7
Copy link
Contributor Author

SHHH and it runs fine I littearly ran the server ;(

@greysilly7
Copy link
Contributor Author

Hey, I know I don't do everything super professional, its all new to me me. However, before writing off the code and saying it won't work, at least try it? I don't even have Bun or NodeJS installed globally on my system, I do per project basis with Nix, so it requiring global dependencies is just inaccurate.

@MathMan05
Copy link
Owner

swc command not found

@greysilly7
Copy link
Contributor Author

greysilly7 commented Apr 23, 2025

Gulp even required installing first, so seems unfair and like this isnt being given real shot

@MathMan05
Copy link
Owner

MathMan05 commented Apr 23, 2025

no? The gulp script works fine. Your script does not and assumes it's installed globally when that's not the case

@greysilly7
Copy link
Contributor Author

No..??????

@MathMan05
Copy link
Owner

yes
image

@greysilly7
Copy link
Contributor Author

greysilly7 commented Apr 23, 2025

[greysilly7@gaminglaptop:~/jank]$ bun run  build --swc
$ bun x gulp --swc
[11:33:27] Loaded external module: /tmp/bunx-1000-gulp@latest/node_modules/interpret/cjs-stub
[11:33:27] Local modules not found in ~/jank
[11:33:27] Try running: npm install
error: script "build" exited with code 1
[greysilly7@gaminglaptop:~/jank]$ npm run build

> jankclient@0.2.0 build
> npx gulp

Need to install the following packages:
gulp@5.0.0
Ok to proceed? (y)

Gulp has the same behavior

@MathMan05
Copy link
Owner

no, it's really not, you're not running gulp as if it were global, so this isn't anywhere near the same thing lol

@greysilly7
Copy link
Contributor Author

[greysilly7@gaminglaptop:~/test]$ bun run build
$ rimraf dist
/run/current-system/sw/bin/bash: line 1: rimraf: command not found
error: script "prebuild" exited with code 127

[greysilly7@gaminglaptop:~/test]$ bun install
bun install v1.2.8 (adab0f64)

+ @eslint/js@9.25.1
+ @html-eslint/eslint-plugin@0.25.0 (v0.39.0 available)
+ @html-eslint/parser@0.27.0 (v0.39.0 available)
+ @stylistic/eslint-plugin@2.13.0 (v4.2.0 available)
+ @stylistic/eslint-plugin-js@2.13.0 (v4.2.0 available)
+ @swc/cli@0.7.3
+ @swc/core@1.11.21
+ @types/compression@1.7.5
+ @types/eslint__js@8.42.3 (v9.14.0 available)
+ @types/express@4.17.21 (v5.0.1 available)
+ @types/node-fetch@2.6.12
+ @typescript-eslint/eslint-plugin@8.31.0
+ @typescript-eslint/parser@8.31.0
+ eslint@8.57.1 (v9.25.1 available)
+ eslint-plugin-html@8.1.2
+ eslint-plugin-sonarjs@1.0.4 (v3.0.2 available)
+ eslint-plugin-unicorn@55.0.0 (v58.0.0 available)
+ prettier@3.5.3
+ rimraf@6.0.1
+ typescript@5.8.3
+ typescript-eslint@8.31.0
+ compression@1.8.0
+ express@4.21.2 (v5.1.0 available)

407 packages installed [1392.00ms]

Blocked 1 postinstall. Run `bun pm untrusted` for details.

[greysilly7@gaminglaptop:~/test]$ bun run build
$ rimraf dist
$ bun run build:compile && bun run build:extras
$ swc ./src -d ./dist --strip-leading-paths --copy-files --source-maps
Successfully compiled: 50 files, copied 54 files with swc (81.25ms)
$ node scripts/build-extras.mjs

You literally just need to install the dependencies first with npm i or bun i

@MathMan05 MathMan05 closed this May 2, 2025
@MathMan05
Copy link
Owner

due to gulp being ditched for a shorter and faster build script ditching swc/cli this is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants