GBFS Go Implementation Rewrite #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re files with values respecting the minimum allowed timestamp for this field. No logic changes or new functionality introduced.
…ew station information and vehicle status data for typescript
…eplacing with direct JSON unmarshalling
…; add unmarshal example code
- Added new vehicle_status and vehicle_types models based on v3.0. - Updated test fixtures for gbfs.json, gbfs_versions.json, geofencing_zones.json, manifest.json, and system_information.json to reflect changes in versioning and TTL. - Introduced new test fixtures for vehicle availability, vehicle status for carsharing and micromobility, and updated pricing plans. - Removed deprecated system_pricing_plans.json and adjusted vehicle_status.json to align with new structure. - Updated all relevant JSON files to use version "3.1-RC2" and adjusted TTL values accordingly.
…chemas to allow all dateTimes that are iso 8601 comlient
^
(\d{4}(-\d{2}(-\d{2})?)?|\d{8}) # Date: YYYY or YYYY-MM or YYYY-MM-DD or YYYYMMDD
T
(
(\d{2}:\d{2}(:\d{2}(\.\d+)?)?) | # Extended time: hh:mm, hh:mm:ss, hh:mm:ss.sss
(\d{2}:\d{2}(\.\d+)?) | # Extended time: hh:mm.mmm
(\d{2}(\.\d+)?) | # Extended time: hh.hhh
(\d{2}(\d{2}(\d{2}(\.\d+)?)?)?) # Basic time: hhmm, hhmmss, hhmmss.sss
)
(Z|[+-]\d{2}(:?\d{2})?)? # Optional timezone: Z or ±hh:mm or ±hhmm
$
- Changed version from 3.1-RC2 to 3.1-RC across multiple JSON files. - Adjusted TTL values in various files, setting some to 0 and others to specific values. - Updated geofencing zones to set ride_through_allowed to false for specific zones. - Added new files for version 3.1-RC2, including gbfs.json, gbfs_versions.json, geofencing_zones.json, manifest.json, and others. - Introduced new station information files for physical and virtual stations with detailed attributes. - Added vehicle availability and status files for carsharing and micromobility vehicles. - Included comprehensive vehicle types with detailed specifications and assets.
- Deleted obsolete test file for GBFS v3.1-RC1. - Created new test file for GBFS v3.1-RC2 with updated schema paths and test functions. - Updated station_information model to include city field and data structure. - Removed unused fields from system_pricing_plans model. - Updated vehicle_types model to reference v3.0 vehicle_types. - Added new models for GBFS v3.1-RC2 including gbfs, gbfs_versions, geofencing_zones, manifest, station_status, system_alerts, system_information, system_pricing_plans, system_regions, vehicle_availability, vehicle_status, and vehicle_types. - Ensured all new models inherit from their respective v3.1-RC counterparts.
…ions - Removed redundant schema loading and validation functions from gbfsv30_test.go, gbfsv31-RC.go, and gbfsv31-RC2.go. - Replaced calls to specific load and validate functions with a unified approach across all test files. - Improved code readability and maintainability by reducing duplication in test implementations.
richfab
requested review from
davidgamez and
Alessandro100
and removed request for
davidgamez
|
Hello @DanielKerger, Thank you very much for this significant open source contribution 🙏 cc @davidgamez @emmambd for the next steps. Thanks, |
|
Hi @DanielKerger, Thanks for this contribution! 🚀 This is a large PR with many changes, and since our team has limited capacity at the moment, it may take us some time to review it thoroughly. We want to ensure that we give it the attention it deserves, so we appreciate your patience while we review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces a rewrite of the GBFS Go implementation, designed to provide full support for GBFS v2.3 and v3.0, v3.1RC, and v3.1RC2 specifications. The previous codebase has been completely replaced due to incompatibilities with current GBFS standards and insufficient type safety across different Feeds and specification versions.
Key Motivations for the Rewrite:
type Version stringwas declared in all Feeds, leading to redundancy and potential inconsistencies.This rewrite establishes a solid foundation for GBFS processing in Go, with improved type safety, better maintainability, complete v2.3, v3.0, and v3.1RC, v3.1RC2 specification coverage, and a clear path for supporting future specification updates.
My changes include:
Breaking Changes: This is a breaking change that requires updating any existing code that depends on the previous GBFS Go implementation. However, this rewrite now provides GBFS v2.3, v3.1RC, and v3.1RC2 support that was entirely missing before, making it a significant upgrade for production use.