Skip to content

MIR-1340 Default ACLs created by CLI and wizard are out of sync and have surprising feature #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

MIR-1340 Default ACLs created by CLI and wizard are out of sync and have surprising feature #1035

merged 1 commit into from
Jul 31, 2024

Conversation

toKrause
Copy link
Contributor

@toKrause toKrause force-pushed the issues/MIR-1340_Default-ACLs-created-by-CLI-and-wizard-are-out-of-sync-and-have-surprising-feature branch from b4775be to 46eeba8 Compare July 25, 2024 11:02
@sebhofmann sebhofmann force-pushed the issues/MIR-1340_Default-ACLs-created-by-CLI-and-wizard-are-out-of-sync-and-have-surprising-feature branch from 46eeba8 to 7a510d1 Compare July 31, 2024 14:45
@sebhofmann
Copy link
Member

sebhofmann commented Jul 31, 2024 •
edited
Loading

There are PMD Issues. Build with CI=true mvn ... to and open mir/mir-wizard/target/pmd.xml sadly these are not visible in console output and not present in the build artifact in github. I can recommend to use https://plugins.jetbrains.com/plugin/1137-pmd which show the issues in the editor while writing code.

@toKrause toKrause changed the title MCR-1340 Default ACLs created by CLI and wizard are out of sync and have surprising feature MIR-1340 Default ACLs created by CLI and wizard are out of sync and have surprising feature Jul 31, 2024
@toKrause toKrause force-pushed the issues/MIR-1340_Default-ACLs-created-by-CLI-and-wizard-are-out-of-sync-and-have-surprising-feature branch 2 times, most recently from 621ee34 to 9494394 Compare July 31, 2024 15:39
@toKrause toKrause force-pushed the issues/MIR-1340_Default-ACLs-created-by-CLI-and-wizard-are-out-of-sync-and-have-surprising-feature branch from 9494394 to 7d48f7f Compare July 31, 2024 15:39
@sebhofmann sebhofmann merged commit b566058 into main Jul 31, 2024
2 checks passed
@sebhofmann sebhofmann deleted the issues/MIR-1340_Default-ACLs-created-by-CLI-and-wizard-are-out-of-sync-and-have-surprising-feature branch July 31, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsteph-de rsteph-de rsteph-de approved these changes

Assignees
No one assigned
Labels
important
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toKrause @sebhofmann @rsteph-de