Include type declarations in build step #1271
Conversation
package.json
Outdated
| "./src/*": "./src/*" | ||
| ".": { | ||
| "import": "./build/index.js", | ||
| "types": "./build/types/index.d.ts" |
There was a problem hiding this comment.
Amazing, thanks! Can you explain why all the d.ts files need to be copied to the /build folder rather than be directly referenced in the /src folder?
There was a problem hiding this comment.
They don't. Both ways work; just a "design" choice. It was my initial proposal in the issue to keep consistency with your build folder approach to have there all the files exported by the library. This includes the types IMO. But you could also reference the files in the src folder and remove the copying step in the vite config file. Your choice :)
There was a problem hiding this comment.
Thanks for the clarification! I think I'd like to err on the side of less code and keep the builds more simple where possible so I've just pushed the changes to reference the types directly in the /src folder. If this looks good to you then we can merge it!
There was a problem hiding this comment.
A bit more difficult to say with the last merge commit, but yes, LGTM. Thanks!
Proposal fix for #1266, as discussed