Jp itn 20240221 #141
Merged
Jp itn 20240221 #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
22
to
30
| from nemo_text_processing.inverse_text_normalization.ja.graph_utils import ( | ||
| INPUT_LOWER_CASED, | ||
| NEMO_SIGMA, | ||
| GraphFst, | ||
| delete_extra_space, | ||
| delete_space, | ||
| generator_main, | ||
| insert_space, | ||
| ) |
Check notice
Code scanning / CodeQL
Unused import Note
| from nemo_text_processing.inverse_text_normalization.ja.taggers.decimal import DecimalFst | ||
| from nemo_text_processing.inverse_text_normalization.ja.taggers.fraction import FractionFst | ||
| from nemo_text_processing.inverse_text_normalization.ja.taggers.ordinal import OrdinalFst | ||
| from nemo_text_processing.inverse_text_normalization.ja.taggers.preprocessor import PreProcessorFst |
Check notice
Code scanning / CodeQL
Unused import Note
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
Applying updates to the docker file Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com>
Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com>
Included Japanese Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com>
Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com>
Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com>
Updates and fixing on the docker file location issue. Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com>
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com>
for more information, see https://pre-commit.ci
nemo_text_processing/inverse_text_normalization/ja/verbalizers/ordinal.py
Fixed
Show fixed
Hide fixed
|
The updated files from previous round of review.
|
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com>
Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com>
Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
|
Updating according to XInchao's comment. |
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
|
updated file nemo_text_processing/inverse_text_normalization/ja/verbalizers/date.py at line 36 for comments |
ekmb
approved these changes
Jul 19, 2024
BuyuanCui
added a commit
that referenced
this pull request
Aug 20, 2024
* adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja gramamrs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * format fixs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removing commented out tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for japanese Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added japanese for tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update Dockerfile Applying updates to the docker file Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update export_grammars.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update pynini_export.py Included Japanese Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update sh_test.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update launch.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update test_sparrowhawk_inverse_text_normalization.sh Updates and fixing on the docker file location issue. Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * restyle Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * configuration issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main; Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issues Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated fraction tagger and test cases Signed-off-by: Alex Cui <alexcui1994@gmail.com> * changed data format for corrections Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added back all 6 tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added ja on line 168 Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated the grammar to resolve empty sparrohawt test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for empty SH test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates for japanese on dates and tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added ITNPostProcessingFst as None Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update pynini_export.py added ITNPOstProcessorFst as None Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py remioviung unused imports Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py removing unnecessary comments Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * removing unsed import Signed-off-by: Alex Cui <alexcui1994@gmail.com> * update for japanese itn Signed-off-by: Alex Cui <alexcui1994@gmail.com> * fixing typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on the normalization comments Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
added a commit
that referenced
this pull request
Sep 19, 2024
* adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja gramamrs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * format fixs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removing commented out tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for japanese Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added japanese for tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update Dockerfile Applying updates to the docker file Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update export_grammars.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update pynini_export.py Included Japanese Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update sh_test.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update launch.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update test_sparrowhawk_inverse_text_normalization.sh Updates and fixing on the docker file location issue. Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * restyle Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * configuration issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main; Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issues Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated fraction tagger and test cases Signed-off-by: Alex Cui <alexcui1994@gmail.com> * changed data format for corrections Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added back all 6 tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added ja on line 168 Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated the grammar to resolve empty sparrohawt test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for empty SH test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates for japanese on dates and tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added ITNPostProcessingFst as None Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update pynini_export.py added ITNPOstProcessorFst as None Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py remioviung unused imports Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py removing unnecessary comments Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * removing unsed import Signed-off-by: Alex Cui <alexcui1994@gmail.com> * update for japanese itn Signed-off-by: Alex Cui <alexcui1994@gmail.com> * fixing typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on the normalization comments Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
added a commit
that referenced
this pull request
Sep 26, 2024
* adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja gramamrs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * format fixs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removing commented out tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for japanese Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added japanese for tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update Dockerfile Applying updates to the docker file Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update export_grammars.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update pynini_export.py Included Japanese Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update sh_test.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update launch.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update test_sparrowhawk_inverse_text_normalization.sh Updates and fixing on the docker file location issue. Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * restyle Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * configuration issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main; Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issues Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated fraction tagger and test cases Signed-off-by: Alex Cui <alexcui1994@gmail.com> * changed data format for corrections Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added back all 6 tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added ja on line 168 Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated the grammar to resolve empty sparrohawt test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for empty SH test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates for japanese on dates and tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added ITNPostProcessingFst as None Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update pynini_export.py added ITNPOstProcessorFst as None Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py remioviung unused imports Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py removing unnecessary comments Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * removing unsed import Signed-off-by: Alex Cui <alexcui1994@gmail.com> * update for japanese itn Signed-off-by: Alex Cui <alexcui1994@gmail.com> * fixing typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on the normalization comments Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
added a commit
that referenced
this pull request
Sep 26, 2024
* adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja gramamrs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * format fixs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removing commented out tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for japanese Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added japanese for tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update Dockerfile Applying updates to the docker file Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update export_grammars.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update pynini_export.py Included Japanese Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update sh_test.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update launch.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update test_sparrowhawk_inverse_text_normalization.sh Updates and fixing on the docker file location issue. Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * restyle Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * configuration issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main; Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issues Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated fraction tagger and test cases Signed-off-by: Alex Cui <alexcui1994@gmail.com> * changed data format for corrections Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added back all 6 tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added ja on line 168 Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated the grammar to resolve empty sparrohawt test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for empty SH test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates for japanese on dates and tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added ITNPostProcessingFst as None Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update pynini_export.py added ITNPOstProcessorFst as None Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py remioviung unused imports Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py removing unnecessary comments Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * removing unsed import Signed-off-by: Alex Cui <alexcui1994@gmail.com> * update for japanese itn Signed-off-by: Alex Cui <alexcui1994@gmail.com> * fixing typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on the normalization comments Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui
added a commit
that referenced
this pull request
Oct 16, 2024
* adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja gramamrs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * format fixs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removing commented out tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for japanese Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added japanese for tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update Dockerfile Applying updates to the docker file Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update export_grammars.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update pynini_export.py Included Japanese Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update sh_test.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update launch.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update test_sparrowhawk_inverse_text_normalization.sh Updates and fixing on the docker file location issue. Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * restyle Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * configuration issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main; Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issues Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated fraction tagger and test cases Signed-off-by: Alex Cui <alexcui1994@gmail.com> * changed data format for corrections Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added back all 6 tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added ja on line 168 Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated the grammar to resolve empty sparrohawt test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for empty SH test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates for japanese on dates and tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added ITNPostProcessingFst as None Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update pynini_export.py added ITNPOstProcessorFst as None Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py remioviung unused imports Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py removing unnecessary comments Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * removing unsed import Signed-off-by: Alex Cui <alexcui1994@gmail.com> * update for japanese itn Signed-off-by: Alex Cui <alexcui1994@gmail.com> * fixing typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on the normalization comments Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <alexcui1994@gmail.com>
ngachchi
pushed a commit
to ngachchi/NeMo-text-processing
that referenced
this pull request
Jun 23, 2025
* adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja gramamrs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * format fixs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removing commented out tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for japanese Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added japanese for tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update Dockerfile Applying updates to the docker file Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update export_grammars.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update pynini_export.py Included Japanese Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update sh_test.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update launch.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update test_sparrowhawk_inverse_text_normalization.sh Updates and fixing on the docker file location issue. Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * restyle Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * configuration issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main; Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issues Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated fraction tagger and test cases Signed-off-by: Alex Cui <alexcui1994@gmail.com> * changed data format for corrections Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added back all 6 tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added ja on line 168 Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated the grammar to resolve empty sparrohawt test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for empty SH test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates for japanese on dates and tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added ITNPostProcessingFst as None Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update pynini_export.py added ITNPOstProcessorFst as None Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py remioviung unused imports Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py removing unnecessary comments Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * removing unsed import Signed-off-by: Alex Cui <alexcui1994@gmail.com> * update for japanese itn Signed-off-by: Alex Cui <alexcui1994@gmail.com> * fixing typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on the normalization comments Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
FredHaa
pushed a commit
to FredHaa/NeMo-text-processing
that referenced
this pull request
Aug 15, 2025
* adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja gramamrs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * format fixs Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removing commented out tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for japanese Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added japanese for tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update Dockerfile Applying updates to the docker file Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update export_grammars.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update pynini_export.py Included Japanese Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update sh_test.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update launch.sh Updates from main Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update test_sparrowhawk_inverse_text_normalization.sh Updates and fixing on the docker file location issue. Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * restyle Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates Signed-off-by: Alex Cui <alexcui1994@gmail.com> * configuration issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main; Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * copied from main Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issue Signed-off-by: Alex Cui <alexcui1994@gmail.com> * space issues Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated fraction tagger and test cases Signed-off-by: Alex Cui <alexcui1994@gmail.com> * changed data format for corrections Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added back all 6 tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * added ja on line 168 Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated the grammar to resolve empty sparrohawt test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated for empty SH test result Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates for japanese on dates and tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added ITNPostProcessingFst as None Signed-off-by: Alex Cui <alexcui1994@gmail.com> * Update pynini_export.py added ITNPOstProcessorFst as None Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py remioviung unused imports Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * Update ordinal.py removing unnecessary comments Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> * removing unsed import Signed-off-by: Alex Cui <alexcui1994@gmail.com> * update for japanese itn Signed-off-by: Alex Cui <alexcui1994@gmail.com> * fixing typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on era abbreviations Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updates on the normalization comments Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Signed-off-by: Buyuan(Alex) Cui <69030297+BuyuanCui@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
PR for Japanese itn instead of #101
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.