-
Notifications
You must be signed in to change notification settings - Fork 125
PR: Add Vietnamese text normalization for cardinal semiotic class #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: folivoramanh <palasek182@gmail.com>
Signed-off-by: folivoramanh <palasek182@gmail.com>
nemo_text_processing/text_normalization/vi/taggers/punctuation.py
Outdated
Show resolved
Hide resolved
nemo_text_processing/text_normalization/vi/taggers/tokenize_and_classify.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the attached feedback, and we should be good to go.
Also, please make sure to update Jenkinsfile
to facilitate CI integration.
nemo_text_processing/text_normalization/vi/data/numbers/__init__.py
Outdated
Show resolved
Hide resolved
nemo_text_processing/text_normalization/vi/data/numbers/digit.tsv
Outdated
Show resolved
Hide resolved
nemo_text_processing/text_normalization/vi/data/numbers/digit_special.tsv
Outdated
Show resolved
Hide resolved
nemo_text_processing/text_normalization/vi/data/numbers/units.tsv
Outdated
Show resolved
Hide resolved
nemo_text_processing/text_normalization/vi/taggers/punctuation.py
Outdated
Show resolved
Hide resolved
nemo_text_processing/text_normalization/vi/taggers/punctuation.py
Outdated
Show resolved
Hide resolved
nemo_text_processing/text_normalization/vi/taggers/tokenize_and_classify.py
Outdated
Show resolved
Hide resolved
nemo_text_processing/text_normalization/vi/taggers/tokenize_and_classify.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the above.
Signed-off-by: folivoramanh <palasek182@gmail.com>
c57c930
to
109d071
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Add first semiotic class - cardinal for Vietnamese text normalization and also request for a staging branch
Before your PR is "Ready for review"
Pre checks:
git commit -s
to sign.pytest
or (if your machine does not have GPU)pytest --cpu
from the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')
).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
pytest
and Sparrowhawk here.__init__.py
for every folder and subfolder, includingdata
folder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
to all newly added Python files?Copyright 2015 and onwards Google, Inc.
. See an example here.try import: ... except: ...
) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.