Skip to content

Conversation

folivoramanh
Copy link

@folivoramanh folivoramanh commented Jun 12, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.
Add first semiotic class - cardinal for Vietnamese text normalization and also request for a staging branch

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

Signed-off-by: folivoramanh <palasek182@gmail.com>
Signed-off-by: folivoramanh <palasek182@gmail.com>
@tbartley94 tbartley94 self-requested a review June 12, 2025 17:37
@zoobereq zoobereq changed the base branch from main to staging_vi_tn June 17, 2025 16:32
@zoobereq zoobereq assigned zoobereq and unassigned zoobereq Jun 17, 2025
@zoobereq zoobereq requested review from zoobereq June 17, 2025 16:42
Copy link
Collaborator

@zoobereq zoobereq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the attached feedback, and we should be good to go.

Also, please make sure to update Jenkinsfile to facilitate CI integration.

Copy link
Collaborator

@zoobereq zoobereq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the above.

Signed-off-by: folivoramanh <palasek182@gmail.com>
@folivoramanh folivoramanh requested a review from zoobereq June 18, 2025 17:23
Copy link
Collaborator

@zoobereq zoobereq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoobereq zoobereq merged commit 2c22d73 into NVIDIA:staging_vi_tn Jun 18, 2025
2 of 3 checks passed
@folivoramanh folivoramanh deleted the vi_tn_staging branch June 19, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants