Skip to content

Conversation

aanil
Copy link
Member

@aanil aanil commented Apr 30, 2025

No description provided.

@aanil aanil added WIP Work in progress no validation labels Apr 30, 2025
@aanil aanil requested a review from kedhammar April 30, 2025 11:25
@kedhammar
Copy link
Contributor

Very late review time 😎

I found some iffy behavior:

  • Write search term foo in column A

    • Table rows update to results A:foo
  • Switch places between column A and B

    • Search term foo is now in column B
    • Column A is seemingly empty
    • Results are still A:foo
  • Delete search term foo from column B

    • Results are still A:foo
  • Update search field of column A to bar

    • Results update accordingly to A:bar

    I still think the PR is an incremental improvement, so I'll approve it :)

@kedhammar
Copy link
Contributor

kedhammar commented Jul 29, 2025

I noticed now on master, the search text does move in tandem with the column!

@aanil
Copy link
Member Author

aanil commented Jul 29, 2025

Very late review time 😎

I found some iffy behavior:

* Write search term `foo` in column `A`
  
  * Table rows update to results `A:foo`

* Switch places between column `A` and `B`
  
  * Search term `foo` is now in column `B`
  * Column `A` is seemingly empty
  * Results are still `A:foo`

* Delete search term `foo` from column `B`
  
  * Results are still `A:foo`

* Update search field of column `A` to `bar`
  
  * Results update accordingly to `A:bar`
  
  I still think the PR is an incremental improvement, so I'll approve it :)

Thank you for the review! I put it on WIP since I wasn't entirely satisfied with it and wanted to look at it later but then I completely forgot I made it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no validation WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants