Skip to content

Add set! methods for QQ/ZZMPolyRingElem #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

fingolfin
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.32%. Comparing base (f143dcb) to head (97433a4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/flint/FlintTypes.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
- Coverage   88.34%   88.32%   -0.03%     
==========================================
  Files          98       98              
  Lines       36207    36211       +4     
==========================================
- Hits        31987    31983       -4     
- Misses       4220     4228       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -636,6 +636,33 @@ function neg!(z::ZZMPolyRingElem, a::ZZMPolyRingElem)
return z
end

#

function set!(z::ZZMPolyRingElem, a::ZZMPolyRingElem)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should also do this to make it more generally useful (based on a concrete need I just had ;-) )

Suggested change
function set!(z::ZZMPolyRingElem, a::ZZMPolyRingElem)
function set!(z::ZZMPolyRingElemOrPtr, a::ZZMPolyRingElemOrPtr; parent::ZZMPolyRing=parent(a))
@ccall libflint.fmpz_mpoly_set(z::Ref{ZZMPolyRingElem}, a::Ref{ZZMPolyRingElem}, parent::Ref{ZZMPolyRing})::Nothing

Or maybe the kwarg should be ctx to better fit with that @lgoettgens does in PR #1911 (which I kinda forgot about, I thought this was long merged... perhaps we can get together on gather later or next week to discuss this)

@fingolfin fingolfin force-pushed the mh/fmpq_fmpz_mpoly-set branch from 4d9633f to ba35a12 Compare January 20, 2025 22:43
@fingolfin fingolfin force-pushed the mh/fmpq_fmpz_mpoly-set branch from ba35a12 to 97433a4 Compare January 20, 2025 22:45
@fingolfin fingolfin merged commit fb7f84d into master Jan 21, 2025
23 of 24 checks passed
@fingolfin fingolfin deleted the mh/fmpq_fmpz_mpoly-set branch January 21, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants