Skip to content

Update CMP to 1.8.0 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .idea/AndroidProjectSystem.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .idea/kotlinc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 10 additions & 1 deletion application/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ kotlin {
implementation(catalog.voyager.koin)

// lifecycle
implementation(catalog.androidx.multplatform.lifecycle.runtime.compose)
implementation(catalog.jetbrains.androidx.lifecycle.runtime.compose)

// compose
implementation(compose.runtime)
Expand All @@ -69,6 +69,7 @@ kotlin {
implementation(compose.material3)
implementation(compose.materialIconsExtended)
implementation(compose.components.resources)
implementation(compose.components.uiToolingPreview)

// koin
implementation(libs.koin.core)
Expand All @@ -77,12 +78,19 @@ kotlin {

androidMain.dependencies {

// compose
implementation(compose.preview)

// koin
implementation(libs.koin.android)
}
}
}

dependencies {
debugImplementation(compose.uiTooling)
}

tasks.register<Tar>("packageReleaseTarGz") {

group = "distribution"
Expand All @@ -108,3 +116,4 @@ tasks.register<Tar>("packageReleaseTarGz") {
aboutLibraries {
prettyPrint = true
}

Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,9 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

@file:OptIn(ExperimentalKotlinGradlePluginApi::class)
@file:Suppress("UnstableApiUsage")

import extension.*
import gradle.kotlin.dsl.accessors._3c98c44ac979be75a1ef93311f530471.kotlin
import gradle.kotlin.dsl.accessors._9d6accdeac6876c73060866945fb6d8c.sourceSets
import org.jetbrains.kotlin.gradle.ExperimentalKotlinGradlePluginApi
import org.jetbrains.kotlin.gradle.dsl.JvmTarget

plugins {
Expand Down Expand Up @@ -56,13 +52,13 @@ kotlin {

android {
namespace = config.basePackage
compileSdk = config.android.compileSdk
compileSdk = catalog.versions.android.compileSdk.get().toInt()

defaultConfig {
applicationId = "com.neo.regex" // Legacy package

minSdk = config.android.minSdk
targetSdk = config.android.targetSdk
minSdk = catalog.versions.android.minSdk.get().toInt()
targetSdk = catalog.versions.android.targetSdk.get().toInt()

versionCode = config.version.code()
versionName = config.version.name()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@

@file:Suppress("UnstableApiUsage")

import extension.catalog
import extension.config
import gradle.kotlin.dsl.accessors._3c98c44ac979be75a1ef93311f530471.kotlin
import gradle.kotlin.dsl.accessors._99f383e9504ff70e774f7d99a658657b.kotlin

plugins {
id("com.android.library")
Expand All @@ -33,12 +34,11 @@ kotlin {
}

android {

namespace = config.basePackage
compileSdk = config.android.compileSdk
compileSdk = catalog.versions.android.compileSdk.get().toInt()

defaultConfig {
minSdk = config.android.minSdk
minSdk = catalog.versions.android.minSdk.get().toInt()
}

buildFeatures {
Expand Down
20 changes: 14 additions & 6 deletions build-logic/src/main/kotlin/com.neoutils.neoregex.core.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,11 @@
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

@file:OptIn(ExperimentalKotlinGradlePluginApi::class)
@file:Suppress("UnstableApiUsage")

import extension.catalog
import extension.config
import extension.module
import extension.name
import org.jetbrains.kotlin.gradle.ExperimentalKotlinGradlePluginApi
import org.jetbrains.kotlin.gradle.dsl.JvmTarget

plugins {
Expand All @@ -48,9 +45,9 @@ kotlin {
}
}

jvm("desktop")
jvm(name = "desktop")

js("web", IR) {
js(name = "web", compiler = IR) {
browser()
binaries.library()
}
Expand All @@ -59,7 +56,7 @@ kotlin {
commonMain.dependencies {

// lifecycle
implementation(catalog.androidx.multplatform.lifecycle.runtime.compose)
implementation(catalog.jetbrains.androidx.lifecycle.runtime.compose)

// compose
implementation(compose.runtime)
Expand All @@ -68,6 +65,7 @@ kotlin {
implementation(compose.material3)
implementation(compose.materialIconsExtended)
implementation(compose.components.resources)
implementation(compose.components.uiToolingPreview)

// koin
implementation(catalog.koin.core)
Expand All @@ -77,6 +75,12 @@ kotlin {
implementation(catalog.kotlinx.datetime)
}

androidMain.dependencies {

// compose
implementation(compose.preview)
}

val desktopMain by getting {
dependencies {
// compose
Expand All @@ -85,3 +89,7 @@ kotlin {
}
}
}

dependencies {
debugImplementation(compose.uiTooling)
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ kotlin {
vendor.set(JvmVendorSpec.JETBRAINS)
}

js(name = "web", IR) {
js(name = "web", compiler = IR) {

moduleName = "app"
outputModuleName = "app"

browser {
commonWebpackConfig {
Expand Down
5 changes: 0 additions & 5 deletions build-logic/src/main/kotlin/extension/Project.kt
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ val config = Config(
patch = 0,
stage = Config.Stage.DEVELOP
),
android = Config.Android(
compileSdk = 34,
minSdk = 24,
targetSdk = 34
),
basePackage = "com.neoutils.neoregex",
name = "NeoRegex"
)
Expand Down
7 changes: 0 additions & 7 deletions build-logic/src/main/kotlin/model/Config.kt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ package model
data class Config(
val name: String,
val version: Version,
val android: Android,
val basePackage: String
) {
data class Version(
Expand All @@ -31,12 +30,6 @@ data class Config(
val stage: Stage
)

data class Android(
val compileSdk: Int,
val minSdk: Int,
val targetSdk: Int
)

enum class Stage(val suffix: String?) {
DEVELOP(suffix = "dev"),
ALPHA(suffix = "alpha"),
Expand Down
4 changes: 2 additions & 2 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ plugins {
alias(libs.plugins.kotlin.multiplatform) apply false
alias(libs.plugins.android.application) apply false
alias(libs.plugins.android.library) apply false
alias(libs.plugins.kmp.compose.compiler) apply false
alias(libs.plugins.kmp.compose) apply false
alias(libs.plugins.compose.compiler) apply false
alias(libs.plugins.compose.multiplatform) apply false
alias(libs.plugins.buildkonfig) apply false
alias(libs.plugins.aboutlibraries) apply false
}
2 changes: 1 addition & 1 deletion core/common/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ kotlin {
commonMain.dependencies {

// NeoUtils
implementation(libs.highlight.compose)
implementation(libs.neoutils.highlight.compose)
}

webTest.dependencies {
Expand Down
2 changes: 1 addition & 1 deletion core/shared-ui/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ kotlin {
implementation(projects.core.manager)

// NeoUtils
implementation(libs.highlight.compose)
implementation(libs.neoutils.highlight.compose)
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion feature/matcher/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ kotlin {
implementation(catalog.voyager.koin)

// NeoUtils
implementation(libs.highlight.compose)
implementation(libs.neoutils.highlight.compose)
}
}
}
2 changes: 1 addition & 1 deletion feature/saved/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ kotlin {
implementation(catalog.voyager.koin)

// NeoUtils
implementation(libs.highlight.compose)
implementation(libs.neoutils.highlight.compose)
}
}
}
2 changes: 1 addition & 1 deletion feature/validator/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ kotlin {
implementation(catalog.voyager.koin)

// NeoUtils
implementation(libs.highlight.compose)
implementation(libs.neoutils.highlight.compose)
}
}
}
Loading
Loading