Skip to content

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Jul 13, 2021

I think this is now safe to do. I haven’t had any issues using ssh-ng, but I suspect most users don’t know
about it.

Relates to #4665

I think this is now safe to do. I haven’t had any issues using ssh-ng, but I suspect most users don’t know
about it.
@edolstra edolstra added this to the nix-3.0 milestone Jul 13, 2021
@Mic92
Copy link
Member

Mic92 commented Jul 15, 2021

Is there any writeup about what the difference between the two is? Do we get a changelog entry for this?

@Mic92
Copy link
Member

Mic92 commented Jul 15, 2021

cc @rickynils since this is a breaking change for nixbuild.net I believe.

@rickynils
Copy link
Member

@Mic92 This shouldn't be breaking for nixbuild.net, since most of documentation for nixbuild.net explicitly states that you should use ssh://eu.nixbuild.net. So as long as the legacy remote builders still are supported, things should be fine for nixbuild.net. I do however intend to support ssh-ng too, since I want nixbuild.net to be completely interchangeable with a "normal" remote builder.

I would also be interested in some comparison between ssh:// and ssh-ng://, although I guess I'll notice the differences when implementing this for nixbuild.net.

@thufschmitt
Copy link
Member

One thing that I think ssh:// does but not ssh-ng:// is respect the builders-use-substitutes flag (I didn’t try it recently, but https://github.com/NixOS/nix/blob/master/src/libstore/remote-store.cc#L291-L308 is ignoring the flag)

@Ericson2314
Copy link
Member

I tried to beef up #4665 to account for this, and potential blockers like what the @regnat mentioned.

@edolstra edolstra modified the milestones: nix-2.5, nix-2.6 Dec 2, 2021
@edolstra edolstra modified the milestones: nix-2.6, nix-2.7 Jan 21, 2022
@edolstra edolstra modified the milestones: nix-2.7, nix-2.8 Mar 3, 2022
@rickynils
Copy link
Member

nixbuild.net now supports ssh-ng:// in addition to ssh://, but it is not documented yet since we want to test it more.

@edolstra edolstra modified the milestones: nix-2.8, nix-2.9 Apr 14, 2022
@edolstra edolstra modified the milestones: nix-2.9, nix-2.10 May 27, 2022
@edolstra edolstra modified the milestones: nix-2.10, nix-2.11 Jul 11, 2022
@edolstra edolstra modified the milestones: nix-2.11, nix-2.12 Aug 25, 2022
@fricklerhandwerk fricklerhandwerk added the security Security-related issues label Sep 9, 2022
@edolstra edolstra modified the milestones: nix-2.12, nix-2.13 Dec 6, 2022
@edolstra edolstra modified the milestones: nix-2.16, nix-2.17 May 31, 2023
@Ericson2314 Ericson2314 added the protocol Things involving the daemon protocol & compatibility issues label Jun 14, 2023
@edolstra edolstra modified the milestones: nix-2.17, nix-2.18 Jul 24, 2023
@edolstra edolstra modified the milestones: nix-2.18, nix-2.19 Sep 20, 2023
@edolstra edolstra modified the milestones: nix-2.19, nix-2.20 Nov 20, 2023
@edolstra edolstra modified the milestones: nix-2.20, nix-2.21 Mar 4, 2024
@edolstra edolstra modified the milestones: nix-2.21, nix-2.22 Mar 11, 2024
@fricklerhandwerk fricklerhandwerk added contributor-experience Developer experience for Nix contributors and removed security Security-related issues labels Apr 17, 2024
@edolstra edolstra modified the milestones: nix-2.22, nix-2.23 Apr 23, 2024
@edolstra edolstra removed this from the nix-2.23 milestone Jun 12, 2024
@nyabinary
Copy link

Any reason why this hasn't been set to default yet?

@kjeremy
Copy link
Contributor

kjeremy commented Sep 19, 2024

I've been using this for a few years now. The only thing that I have run into is that ssh-ng stores do not work with nix log.

@Mic92
Copy link
Member

Mic92 commented Sep 20, 2024

@Enzime knows about a reason: nix-community/nixos-anywhere#366

@Mic92
Copy link
Member

Mic92 commented Sep 20, 2024

Basically this issue: #7359

@Enzime
Copy link
Member

Enzime commented Sep 22, 2024

Not sure if this has been fixed yet #6950

@Ericson2314
Copy link
Member

I would like to try doing this. (Another alternative is simply forcing the user to be explicit.)

@tomberek tomberek moved this from To triage to ⚖ To discuss in Nix team Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor-experience Developer experience for Nix contributors protocol Things involving the daemon protocol & compatibility issues
Projects
Status: ⚖ To discuss
Development

Successfully merging this pull request may close these issues.

10 participants