Vmimo/clean for ocp merge #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam/revert-latest-commit
Setup Solidity formater
Mainnet Migration
…_id` less likely to cause collision
…keholderSecurities` function will return securities belongs only to the stakeholder
- Implement tests for successful consolidation of stock positions, ensuring unique security IDs after transfers. - Add failure cases for consolidating with empty positions, zero quantity positions, and mismatched stock classes. - Validate weighted average price calculation during consolidation. - Include handling of extreme quantities in stock transfers to ensure robustness. Enhancements to the DiamondStockTransferTest contract to improve coverage and error handling for stock transfers and consolidations.
- Add structured `StockConsolidationTx` and `StockTransferTx` structs in Solidity - Update JavaScript transaction handlers to use new structured transaction types - Create new consolidation transaction model in database - Simplify transaction mapping and remove unnecessary fields - Remove `isBuyerVerified` parameter from stock transfer controller
[Feat] Stock Transfer with Consolidation
Split fairmint routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?