Skip to content

Main Merge #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 181 commits into from
Feb 10, 2025
Merged

Main Merge #36

merged 181 commits into from
Feb 10, 2025

Conversation

victormimo
Copy link
Collaborator

@victormimo victormimo commented Feb 10, 2025

  • few months delayed.. OCP V2. Diamond.

AdamMomen and others added 29 commits December 28, 2024 17:16
…keholderSecurities` function will return securities belongs only to the stakeholder
- Implement tests for successful consolidation of stock positions, ensuring unique security IDs after transfers.
- Add failure cases for consolidating with empty positions, zero quantity positions, and mismatched stock classes.
- Validate weighted average price calculation during consolidation.
- Include handling of extreme quantities in stock transfers to ensure robustness.

Enhancements to the DiamondStockTransferTest contract to improve coverage and error handling for stock transfers and consolidations.
- Add structured `StockConsolidationTx` and `StockTransferTx` structs in Solidity
- Update JavaScript transaction handlers to use new structured transaction types
- Create new consolidation transaction model in database
- Simplify transaction mapping and remove unnecessary fields
- Remove `isBuyerVerified` parameter from stock transfer controller
[Feat] Stock Transfer with Consolidation
@victormimo victormimo merged commit c15d07b into main Feb 10, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants