Skip to content

Allow SOMD1 pert file to be created without modifications to ghost atom bonded terms #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 30, 2025

Conversation

lohedges
Copy link
Contributor

This PR modifies the SOMD1 pert file writer to allow it to be written without modifications to ghost atom bonded terms. This enables the use of external modifications, e.g. those generated by the SOMD2 ghostly tool.

The PR also includes a few fixes for running simulations of perturbable systems at the lambda = 1 end state and also when restraints are present.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have added a test for any new functionality in this pull request: [y]
  • I confirm that I have added documentation (e.g. a new tutorial page or detailed guide) for any new functionality in this pull request: [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

@lohedges lohedges requested a review from mb2055 June 20, 2025 13:14
@lohedges lohedges added the enhancement New feature or request label Jun 20, 2025
@lohedges lohedges had a problem deploying to biosimspace-build June 20, 2025 13:14 — with GitHub Actions Failure
@lohedges lohedges had a problem deploying to biosimspace-build June 20, 2025 13:14 — with GitHub Actions Failure
@lohedges lohedges had a problem deploying to biosimspace-build June 20, 2025 13:14 — with GitHub Actions Failure
@lohedges lohedges had a problem deploying to biosimspace-build June 20, 2025 13:14 — with GitHub Actions Failure
@lohedges lohedges had a problem deploying to biosimspace-build June 20, 2025 13:14 — with GitHub Actions Failure
Copy link
Contributor

@mb2055 mb2055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this branch for my ghostly testing and everything seems to be working well 👍

@lohedges lohedges merged commit eb9ff4a into devel Jun 30, 2025
0 of 5 checks passed
@lohedges lohedges deleted the feature_no_ghost_mods branch July 1, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants