Skip to content

Conversation

DawidWesierski4
Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 commented May 27, 2025

Add support for 8331 adjacent ancillary data
input for the GStreamer st40 ancillary data plugin.
Which allows the user to take input from
https://www.[ietf.org/rfc/rfc8331.html](https://www.ietf.org/rfc/rfc8331.html)
Starting ANC_Count and ending with word_align.

Add support for buffer size for UDW support
that allows the user to change the size of the
buffers, set it to the maximum by default
as the wasted size of appropriately
2kb * framebuffer count is acceptable.

Change the st40p api to hide the metadata,
which should be clearer for users.

Refactor: Isolate the parsing of data into
gst_mtl_st40p_tx_parse_* functions.

Fix the issue with the GST buffer size being taken from
the whole GstBuffer instead of the mapped
GstMemory.

@DawidWesierski4 DawidWesierski4 force-pushed the anc branch 3 times, most recently from 2d3a08c to b34c3fb Compare May 29, 2025 14:41
@DawidWesierski4 DawidWesierski4 changed the title Anc Add: GStreamer plugin 8331 input support May 29, 2025
@DawidWesierski4 DawidWesierski4 force-pushed the anc branch 4 times, most recently from 96a994b to fd9e822 Compare May 29, 2025 14:48
Add support for 8331 adjacent ancillary data
input for GStreamer st40 ancillary data plugin.

Isolate the existing frame parsing into,
@DawidWesierski4 DawidWesierski4 marked this pull request as ready for review May 29, 2025 18:38
@MateuszGrabuszynski
Copy link
Collaborator

MateuszGrabuszynski commented Jun 2, 2025

Connected to issue #1151.

EDIT: Crossed out as per Dawid's comment.

@DawidWesierski4
Copy link
Collaborator Author

Connected to issue #1151.

Nope i wanted to resolve this all in this ticket but too much in one go
This struct is used in the ancillary session packet creation,
We would need to include validaiton for BE, wchich is not there for now,

I'm going to create a new PR, and resolve it in seprate issue

Copy link
Collaborator

@Sakoram Sakoram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Good job

Ps.
We need to add unit tests for this GST element asap

@DawidWesierski4 DawidWesierski4 merged commit dd61100 into OpenVisualCloud:main Jun 5, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants