-
Notifications
You must be signed in to change notification settings - Fork 72
Add: GStreamer plugin 8331 input support #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d3a08c
to
b34c3fb
Compare
96a994b
to
fd9e822
Compare
Add support for 8331 adjacent ancillary data input for GStreamer st40 ancillary data plugin. Isolate the existing frame parsing into,
EDIT: Crossed out as per Dawid's comment. |
Nope i wanted to resolve this all in this ticket but too much in one go I'm going to create a new PR, and resolve it in seprate issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Good job
Ps.
We need to add unit tests for this GST element asap
Add support for 8331 adjacent ancillary data
input for the GStreamer st40 ancillary data plugin.
Which allows the user to take input from
https://www.[ietf.org/rfc/rfc8331.html](https://www.ietf.org/rfc/rfc8331.html)
Starting ANC_Count and ending with word_align.
Add support for buffer size for UDW support
that allows the user to change the size of the
buffers, set it to the maximum by default
as the wasted size of appropriately
2kb * framebuffer count is acceptable.
Change the st40p api to hide the metadata,
which should be clearer for users.
Refactor: Isolate the parsing of data into
gst_mtl_st40p_tx_parse_* functions.
Fix the issue with the GST buffer size being taken from
the whole GstBuffer instead of the mapped
GstMemory.