Skip to content

FIX: duplicated dpdk install step #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2025
Merged

FIX: duplicated dpdk install step #1166

merged 4 commits into from
Jun 4, 2025

Conversation

zLukas
Copy link
Contributor

@zLukas zLukas commented Jun 3, 2025 •
edited
Loading

FIX:

  • move duplicated DPDK install steps from each build workflow into standalone to action
  • replace DPDK install steps in workflows with action

@zLukas zLukas marked this pull request as ready for review June 3, 2025 08:35
@zLukas zLukas enabled auto-merge (squash) June 3, 2025 10:03
@DawidWesierski4 DawidWesierski4 changed the title add dpdk action Add: dpdk action Jun 3, 2025
DawidWesierski4
DawidWesierski4 reviewed Jun 3, 2025
View reviewed changes
DawidWesierski4
DawidWesierski4 requested changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change commit message title

@DawidWesierski4
Copy link
Collaborator

Please
Sqash commits so they make sense

image

FIx ? and Add ?
What is this commit doing ?
What the failure -> how is it fixed ?
I don't understand the commit message

zLukas added 4 commits June 4, 2025 07:24
@zLukas
add dpdk action
11aec50 
add dpdk action

add dpdk action

add dpdk action

add dpdk action
@zLukas
replace dpdk install with action
c956f23
@zLukas
update env vars in workflows
2e5496a 
update action name

update action name

update inputs in action
@zLukas
revoke tests changes
01ce9e8
@zLukas zLukas force-pushed the zlukas/fix_dpdk_instalation branch from 8ce0766 to 01ce9e8 Compare June 4, 2025 07:34
@zLukas zLukas changed the title Add: dpdk action FIX: duplicated dpdk install step Jun 4, 2025
DawidWesierski4
DawidWesierski4 approved these changes Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variables will be taken from the file versions.env in consequent PR

@zLukas zLukas merged commit 763f0b6 into main Jun 4, 2025
29 checks passed
@zLukas zLukas deleted the zlukas/fix_dpdk_instalation branch June 4, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DawidWesierski4 DawidWesierski4 DawidWesierski4 approved these changes

@Sakoram Sakoram Awaiting requested review from Sakoram Sakoram is a code owner

@skolelis skolelis Awaiting requested review from skolelis

@Falron98 Falron98 Awaiting requested review from Falron98 Falron98 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zLukas @DawidWesierski4