Skip to content

Conversation

zLukas
Copy link
Contributor

@zLukas zLukas commented Jun 9, 2025

Add CI/CD build jobs that use a common parametrised script
Remove redundant build pipelines

@zLukas zLukas marked this pull request as ready for review June 13, 2025 08:51
@zLukas zLukas requested a review from DawidWesierski4 June 13, 2025 08:51
@DawidWesierski4 DawidWesierski4 changed the title Clean-up build pipelines Ci: Clean-up build pipelines Jun 23, 2025
Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SETUP_BUILD_AND_INSTALL_GPU_DIRECT
TOOLS_BUILD_AND_INSTALL_MTL_MONITORS
TOOLS_BUILD_AND_INSTALL_MTL_READPCAP
TOOLS_BUILD_AND_INSTALL_MTL_CPU_EMULATOR

Are not enabled in the build

@zLukas
Copy link
Contributor Author

zLukas commented Jun 23, 2025

SETUP_BUILD_AND_INSTALL_GPU_DIRECT TOOLS_BUILD_AND_INSTALL_MTL_MONITORS TOOLS_BUILD_AND_INSTALL_MTL_READPCAP TOOLS_BUILD_AND_INSTALL_MTL_CPU_EMULATOR

Are not enabled in the build

fixed

@DawidWesierski4
Copy link
Collaborator

Hi my bad

Tool TOOLS_BUILD_AND_INSTALL_MTL_MONITORS has an EBPF XDP dependency that I didn't notice and should be "removed" from the base build by default, then all should pass and work as intended IMO

Please remove the TOOLS_BUILD_AND_INSTALL_MTL_MONITORS from the build without ebpf (Base Build / ubuntu-build)

I'm fine with the rest, but please have someone knowledgeable about the github actions have a second look at this as I'm just a rookie in that regard

Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ask sombady knowledgable in github actions about this pr for a review I'm just a rookie

Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see everything passed but please add another review

@DawidWesierski4 DawidWesierski4 merged commit d608256 into main Jun 26, 2025
16 checks passed
@DawidWesierski4 DawidWesierski4 deleted the zlukas/clean_up_build_workflows branch June 26, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants