-
Notifications
You must be signed in to change notification settings - Fork 72
Ci: Clean-up build pipelines #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SETUP_BUILD_AND_INSTALL_GPU_DIRECT
TOOLS_BUILD_AND_INSTALL_MTL_MONITORS
TOOLS_BUILD_AND_INSTALL_MTL_READPCAP
TOOLS_BUILD_AND_INSTALL_MTL_CPU_EMULATOR
Are not enabled in the build
fixed |
Hi my bad Tool TOOLS_BUILD_AND_INSTALL_MTL_MONITORS has an EBPF XDP dependency that I didn't notice and should be "removed" from the base build by default, then all should pass and work as intended IMO Please remove the TOOLS_BUILD_AND_INSTALL_MTL_MONITORS from the build without ebpf (Base Build / ubuntu-build) I'm fine with the rest, but please have someone knowledgeable about the github actions have a second look at this as I'm just a rookie in that regard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ask sombady knowledgable in github actions about this pr for a review I'm just a rookie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see everything passed but please add another review
Add CI/CD build jobs that use a common parametrised script
Remove redundant build pipelines