Add: experimental st40p api flag for queue stats #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawidWesierski4
requested review from
Sakoram,
skolelis and
Falron98
as code owners
Add experimental st40p api flag for our framebuffer queue statistics. This will allow user to see clearly how many frames are in which queue state. Example output: TX_st40p(0,st40sink), stat free: 15 TX_st40p(0,st40sink), stat in_user: 0 TX_st40p(0,st40sink), stat ready: 12 TX_st40p(0,st40sink), stat in_transmitting: 1 We are assuming this may be inaccurate as no locking is done on the queue, but it is useful for debugging purposes. We could possibly replace the current stats for consumer / producer. For now we are keeping it as an optional feature.
Sakoram
reviewed
Jun 10, 2025
Sakoram
reviewed
Jun 10, 2025
DawidWesierski4
force-pushed
the
states_framebuffs
branch
from
f020f88 to
c625fe2
Compare
Sakoram
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add experimental st40p api flag for our
framebuffer queue statistics. This will allow
the user to see clearly how many frames are in
which queue state.
Example output:
TX_st40p(0,st40sink), stat free: 15
TX_st40p(0,st40sink), stat in_user: 0
TX_st40p(0,st40sink), stat ready: 12
TX_st40p(0,st40sink), stat in_transmitting: 1
We are assuming this may be inaccurate, as no
locking is done on the queue, but it is
useful for debugging purposes.
We could possibly replace the current stats for
consumer/producer.
For now, we are keeping it as an optional
feature.