Skip to content

Add: FFmpeg based end-to-end latency measurement #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Add: FFmpeg based end-to-end latency measurement #1177

merged 1 commit into from
Jun 17, 2025

Conversation

tszumski
Copy link
Collaborator

No description provided.

@tszumski tszumski force-pushed the tszumski-latency-measurement branch 4 times, most recently from 743e993 to 1fe8013 Compare June 16, 2025 08:00
DawidWesierski4
DawidWesierski4 reviewed Jun 16, 2025
View reviewed changes
Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test this as i don't have ubuntu environment on hand, so only face level comments

Plesase change the name of the doc/LatencyMeasurement.md
to doc/latency_measurement.md

text-detection.py -> text_detection.py

we don't use PascalCase for file names

DawidWesierski4
DawidWesierski4 reviewed Jun 16, 2025
View reviewed changes
@tszumski
Copy link
Collaborator Author

I cannot test this as i don't have ubuntu environment on hand, so only face level comments

Plesase change the name of the doc/LatencyMeasurement.md to doc/latency_measurement.md

text-detection.py -> text_detection.py

we don't use PascalCase for file names

Meanwhile I see:

<repo_dir>/doc/png/desktop-streaming-mtl.png
<repo_dir>/doc/png/mtl-appliance-use-case.png
<repo_dir>/doc/png/xdp-mtl.svg

@DawidWesierski4
Copy link
Collaborator

DawidWesierski4 commented Jun 16, 2025 •
edited
Loading

I cannot test this as i don't have ubuntu environment on hand, so only face level comments
Plesase change the name of the doc/LatencyMeasurement.md to doc/latency_measurement.md
text-detection.py -> text_detection.py
we don't use PascalCase for file names

Meanwhile I see:

<repo_dir>/doc/png/desktop-streaming-mtl.png
<repo_dir>/doc/png/mtl-appliance-use-case.png
<repo_dir>/doc/png/xdp-mtl.svg

image
image

looks a lil odd innit?

@tszumski tszumski force-pushed the tszumski-latency-measurement branch 2 times, most recently from f4bc5a9 to 5c1e6ee Compare June 17, 2025 08:20
@tszumski tszumski force-pushed the tszumski-latency-measurement branch from 5c1e6ee to 6c06564 Compare June 17, 2025 10:49
DawidWesierski4
DawidWesierski4 approved these changes Jun 17, 2025
View reviewed changes
Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DawidWesierski4 DawidWesierski4 merged commit e62c41b into OpenVisualCloud:main Jun 17, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DawidWesierski4 DawidWesierski4 DawidWesierski4 approved these changes

@Sakoram Sakoram Awaiting requested review from Sakoram Sakoram is a code owner

@skolelis skolelis Awaiting requested review from skolelis

@Falron98 Falron98 Awaiting requested review from Falron98 Falron98 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tszumski @DawidWesierski4 @Sakoram