Add: Unified stats retrival api #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawidWesierski4
force-pushed
the
logging_api_unification
branch
10 times, most recently
from
b1fd994 to
e613df4
Compare
DawidWesierski4
force-pushed
the
logging_api_unification
branch
3 times, most recently
from
2ce93f4 to
a7a57d5
Compare
Add unified api to retrive the sessions stats, for both the legacy and pipeline sessions. This could be made much more elegantly with a union but for the sake of unifying the approach i decided to add all this boilerplate, 3.6 times more code, not great not terrible
|
What do you thing about creating one common structure with common stat values like stat_epoch_drop and including this struct as field in specific structures for stX0? I hate code repetition |
DawidWesierski4
force-pushed
the
logging_api_unification
branch
2 times, most recently
from
8c53850 to
43bd78a
Compare
Sakoram
reviewed
Aug 14, 2025
Sakoram
reviewed
Aug 14, 2025
DawidWesierski4
force-pushed
the
logging_api_unification
branch
2 times, most recently
from
c721248 to
04fb96a
Compare
Sakoram
reviewed
Aug 18, 2025
Sakoram
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unified api to retrive the sessions stats,
for both the legacy and pipeline sessions.