Initial work on deprecating ByColumnAndRow
methods in Worksheet
#2718
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Issue #2717
Initial work on deprecating
ByColumnAndRow
methods in Worksheet; and providing functionality to use the basic cellAddress methods to be used with a string cell address (e.g.C5
); an array of columnId and rowId (e.g.[3, 5]
) or a new CellAddress object.Current implementation for all methods that take a single cell reference argument:
setCellValue()
setCellValueExplicit()
getCell()
cellExists()
setBreak()
freezePane()
getComment()
Also introducing a CellRange object to work with similar cases for methods that accept a cell range rather than simply a cell address.
Current implementation for all methods that take a cell range reference argument; noting that protected cells or style can be individual cells or a range:
mergeCells()
unmergeCells()
protectCells()
unprotectCells()
setAutoFilter()
getStyle()
Then there's a few special cases like
setSelectedCells()
still to complete.It's also worth noting that I've tightened up validation a bit; and also want to make some further modifications to better support passing a Named Range to these methods.
This is:
Checklist:
Why this change is needed?
Deprecation to simplify the Worksheet object and provide more consistency in methods