Stop binding numerically formatted strings as TYPE_NUMERIC

[jdufresne]

Now, string values are always treated as TYPE_STRING. To store a numeric value using the type auto-detection logic, one should a numeric type.

Fixes #752

This is a new feature

Checklist:

• Changes are covered by unit tests
• Code style is respected
• Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
• CHANGELOG.md contains a short summary of the change
• Documentation is updated as necessary

Why this change is needed?

See issue #752

[jdufresne]

Maybe instead of removing it, this should be moved to AdvancedValueBinder.

[MarkBaker]

I really am not comfortable with this change of behaviour.... we created the concept of binders to allow advanced users to control datatyping, while providing the default as something that simplified datatype handling for less advance users.... and I spend more than enough time explaining to people that '2018-11-12 is not a date, but a string representing a date... if we force all datatypes to be string by default, then it will simply increase that level of difficulty for people who aren't as understanding of datatypes,, and there are a lot of user out there that simply don't understand PHP or Excel datatypes, and who simply trust that simplicity to do the work for them.

[MarkBaker]

The logic being removed here assesses the value of strings containing numeric values to see if they begin with a leading zero; and if so, treats them as strings.... the "non-greedy" evaluation of numeric values is supposed to handle telephone numbers, social security numbers, etc such as '0123456' as strings rather than setting them as a numeric type.
It was deliberately adopted as a compromise behaviour; to satisfy those who wanted to retain string datatyping for certain types of numeric values, while retaining the simplicity of automatic typing for those who wanted ease of use.

[jdufresne]

if we force all datatypes to be string by default ...

That is not what I'm suggesting. I'm suggesting that string types be treated as strings. Integers, floating point numbers, date objects, etc. should still be stored in the document as the more obvious type.

[MarkBaker]

OK, my bad.... but that does not change my opinion on this issue. That vast majority of PHP developers using this library do not fully understand datatyping and the differences between 123 and '123'. They take data from an on-screen form or from a csv file, which comes as a string (I've even seen databases that use varchar for everything) and expect it to work as a number. That is the reason for the default. For the more advanced user, who does understand those differences, then it is a single line of code to switch to using a different value binder.
I'm more than happy to include a new binder in the library that gives you string numerics as strings, but not as the default behaviour.

[PowerKiKi]

Mark opinion seems to join my own.

@jdufresne if you are willing to modify this PR, or create a new one, to have a new StrictTypesBinder (or similar naming), which would be available for everyone, but not the default one, then please do so.

If you'd rather not invest more time in this, then we'll close as WONTFIX, because Mark and myself probably won't have much time to implement it ourselves.

[jdufresne]

Thanks for taking the time to respond. I won't have the time to continue working on this so I'll close this PR for now. Cheers.