Skip to content

Pin Biome version in GitHub CI to match package.json #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025

Conversation

MahmoudElsayad
Copy link
Contributor

@MahmoudElsayad MahmoudElsayad commented Jun 19, 2025

Context: Failing CI here

The GitHub CI was failing with the following error: Found an unknown key ignore.. This occurred because the GitHub Action was using version: latest which installed Biome 2.0, it introduced breaking changes to the configuration format like the ignore and include fields have been replaced with a single includes field and new set of defaults that would require some work to move to Biome 2.0.

Fastest solution is to match package.json version on CI as well.

@MahmoudElsayad MahmoudElsayad self-assigned this Jun 19, 2025
@MahmoudElsayad MahmoudElsayad changed the title Pin Biome version to 1.9.4 in GitHub workflow Pin Biome version in GitHub CI to match package.json Jun 19, 2025
@MahmoudElsayad MahmoudElsayad marked this pull request as ready for review June 19, 2025 12:08
Copy link
Contributor

@miguelcalderon miguelcalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will we remember to update this when the package.json version changes? Some build check?

@MahmoudElsayad
Copy link
Contributor Author

@miguelcalderon Thanks for hint, added now.

Copy link
Contributor

@miguelcalderon miguelcalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great! 🎉

@MahmoudElsayad MahmoudElsayad merged commit fb840de into main Jun 19, 2025
3 checks passed
miguelcalderon pushed a commit that referenced this pull request Jul 28, 2025
…-workflow

Pin Biome version in GitHub CI to match `package.json`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants