[perf] Add thread pool execution to data processing #3379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
ltd0924
reviewed
Aug 13, 2025
| @@ -50,6 +53,7 @@ def __init__( | |||
| enable_logprob=False, | |||
| workers=1, | |||
| tool_parser=None, | |||
| data_processor_max_workers=5, | |||
| @@ -123,7 +135,7 @@ def add_requests(self, task): | |||
| Returns: | |||
| None | |||
| """ | |||
|
|
|||
| api_server_logger.info(f"add_requests:{task} in [thread.{threading.current_thread().name}]") | |||
ltd0924
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a thread pool to improve the execution of data processing tasks. The main changes include:
Adding a configurable thread pool to handle concurrent data processing.
Updating relevant functions to submit tasks to the thread pool.
Ensuring proper shutdown and resource management for threads.
Benefits:
Improved performance for large-scale data processing.
Better utilization of system resources.
Easier scalability for future enhancements.
Testing:
Verified data processing completes successfully with multiple threads.
Confirmed no resource leaks or deadlocks during execution.