-
Notifications
You must be signed in to change notification settings - Fork 596
add error traceback info #3419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add error traceback info #3419
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request enhances error handling across the codebase by adding detailed traceback information to error messages and logging statements. The changes improve debugging capabilities by providing full stack traces alongside original error messages.
Key changes include:
- Adding
import traceback
statements to multiple files - Appending
{str(traceback.format_exc())}
to error messages and log statements - Converting some debug-level logging to error-level for tool parsing failures
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
test/ce/deploy/deploy.py | Enhanced error messages in deployment functions with traceback info |
test/ce/accuracy_cases/gsm8k.py | Added traceback to model query error handling |
fastdeploy/worker/utils.py | Improved checkpoint validation error messages |
fastdeploy/splitwise/splitwise_connector.py | Enhanced error logging in message processing and network operations |
fastdeploy/scheduler/splitwise_scheduler.py | Added traceback to scheduler error handling and fixed undefined variable bug |
fastdeploy/scheduler/global_scheduler.py | Enhanced keep-alive error logging |
fastdeploy/platforms/*.py | Improved platform availability check error messages |
fastdeploy/output/token_processor.py | Enhanced error logging in token processing |
fastdeploy/model_executor/guided_decoding/*.py | Improved error handling in grammar compilation and tokenizer initialization |
fastdeploy/inter_communicator/*.py | Enhanced ZMQ communication error logging |
fastdeploy/input/ernie_vl_processor.py | Improved multimodal processor error handling |
fastdeploy/entrypoints/openai/*.py | Enhanced API error handling with detailed tracebacks |
fastdeploy/entrypoints/*.py | Improved client and server error logging |
fastdeploy/engine/*.py | Enhanced engine and service error handling |
fastdeploy/cache_manager/*.py | Improved cache management error logging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
add error traceback info