[Excutor] Change cudagraph hashkey from batch size to num_tokens #3454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
|
||
| # Concrete batch size | ||
| # Concrete shape | ||
| runtime_bs: int |
There was a problem hiding this comment.
runtime_bs -> captured_size 下一个PR改吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
实际上原本的逻辑就是根据实际这一轮的num_tokens数
ids_remove_padding.shape[0]去作为hashkey，这里只是更改相关变量与注释的名字，不显式使用含有batch size的变量，为后续mtp和prefill进入cudagraph做准备。