[API Compatibility] Add out support for 11 APIs #74592

LittleHeroZZZX · 2025-08-13T08:08:09Z

PR Category

User Experience

PR Types

New features

Description

为 11 个 API 添加 out 、参数映射、下沉 C++，并添加对应单元测试。具体清单为：
paddle.polar
paddle.stack
paddle.cos
paddle.floor
paddle.log
paddle.pow
paddle.rsqrt
paddle.sign
paddle.sin
paddle.multiply

其中，multiply 由于不在 ops.yaml 清单中，留给 @DanielSun11 下沉至 C++。

下沉到 C++ 的算子不再支持就旧静态图组网，涉及到这部分的单测直接注释。

paddle-bot · 2025-08-13T08:08:18Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhwesky2010

LGTM

SigureMo

LGTMeow for type annotations

SigureMo · 2025-08-13T09:30:42Z

python/paddle/tensor/creation.py

        out (Tensor|None, optional): The output tensor. Default: None.
+        name(str|None, optional): For details, please refer to :ref:`api_guide_Name`. Generally, no setting is required. Default: None.


可以帮忙给这个 API 也加一下类型提示么？

SigureMo · 2025-08-13T10:37:16Z

python/paddle/tensor/creation.py

+    out: paddle.Tensor | None = None,
+    name: str | None = None,


问一下，这些 API 里的 out 和 name 是否应该作为「仅关键字参数」呢？即 3397 行前是不是应该加一个 *？只是疑问 @zhwesky2010

LittleHeroZZZX · 2025-08-14T10:13:38Z

/re-run all-failed

XiaoguangHu01

LGTM

codecov-commenter · 2025-08-14T14:27:25Z

Codecov Report

❌ Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@f1ae790). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
python/paddle/tensor/creation.py	50.00%	2 Missing ⚠️
python/paddle/tensor/manipulation.py	0.00%	2 Missing ⚠️
python/paddle/nn/quant/functional_layers.py	88.88%	1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (86.84%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #74592   +/-   ##
==========================================
  Coverage           ?   86.84%           
==========================================
  Files              ?        5           
  Lines              ?       38           
  Branches           ?        0           
==========================================
  Hits               ?       33           
  Misses             ?        5           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

LittleHeroZZZX · 2025-08-14T17:03:33Z

/re-run all-failed

zhwesky2010 · 2025-08-20T10:05:01Z

python/paddle/tensor/math.py

@@ -1241,7 +1195,9 @@ def remainder_(x: Tensor, y: Tensor, name: str | None = None) -> Tensor:
    """


-def multiply(x: Tensor, y: Tensor, name: str | None = None) -> Tensor:
+def multiply(


这个能下沉吗

这个不在 ops.yaml 中

zhwesky2010 · 2025-08-20T10:07:22Z

test/legacy_test/test_activation_op.py

 )
 create_test_act_bf16_class(
-    TestRsqrt, check_prim=True, check_pir=True, check_prim_pir=True
+    TestRsqrt, check_prim=False, check_pir=True, check_prim_pir=True


单测这些改动是因为跑不过吗

是的，check_prim 是测旧静态图的。

test/dygraph_to_static/test_pylayer.py

LittleHeroZZZX · 2025-08-20T16:30:46Z

/re-run all-failed

test/legacy_test/test_layer_norm_op.py

LittleHeroZZZX · 2025-08-21T05:33:12Z

/re-run all-failed

LittleHeroZZZX · 2025-08-21T06:00:54Z

/re-run all-failed

LittleHeroZZZX · 2025-08-21T08:51:58Z

/re-run all-failed

zhwesky2010

LGTM

LittleHeroZZZX · 2025-08-21T10:16:24Z

/re-run all-failed

LittleHeroZZZX · 2025-08-21T10:37:21Z

/re-run all-failed

Add 11 APIs depending on out

2ef9c85

zhwesky2010 added the API Compatibility label Aug 13, 2025

zhwesky2010 previously approved these changes Aug 13, 2025

View reviewed changes

zhwesky2010 requested review from SigureMo and zyfncg August 13, 2025 09:27

SigureMo previously approved these changes Aug 13, 2025

View reviewed changes

Add tyoe hint for complex

fdce7a4

LittleHeroZZZX dismissed stale reviews from SigureMo and zhwesky2010 via fdce7a4 August 13, 2025 11:20

SigureMo previously approved these changes Aug 13, 2025

View reviewed changes

restrict out param to be keyword-only argument

145a9b6

LittleHeroZZZX dismissed SigureMo’s stale review via 145a9b6 August 14, 2025 02:15

adapt name param

e5ce1cb

SigureMo previously approved these changes Aug 14, 2025

View reviewed changes

put name before keyword-only argument

a7b2aba

LittleHeroZZZX dismissed SigureMo’s stale review via a7b2aba August 14, 2025 06:59

zhwesky2010 previously approved these changes Aug 14, 2025

View reviewed changes

SigureMo previously approved these changes Aug 14, 2025

View reviewed changes

XiaoguangHu01 previously approved these changes Aug 14, 2025

View reviewed changes

LittleHeroZZZX marked this pull request as draft August 15, 2025 07:03

LittleHeroZZZX added 4 commits August 15, 2025 07:05

Merge remote-tracking branch 'origin/develop' into feat/out_ops2

11a2970

Merge remote-tracking branch 'origin/develop' into feat/out_ops2

bee131a

Enable unittests

8346a92

Test C++ lowering test - sin

32a1211

LittleHeroZZZX dismissed stale reviews from XiaoguangHu01 and SigureMo via 32a1211 August 18, 2025 03:08

LittleHeroZZZX added 8 commits August 19, 2025 06:14

add out ops

19ecd26

refine doc for sin

1f59707

Remove old ir tests

b3b39f5

Merge branch 'develop' into feat/out_ops2

d4a9f4f

Comment the deprecated ut

2240405

Refine codestyle

f120923

Remove ParamAlais for multiply

4a56b23

Use use_default_mapping in ops.yaml

a8782fb

LittleHeroZZZX marked this pull request as ready for review August 20, 2025 08:03

LittleHeroZZZX requested review from DrRyanHuang, zrr1999 and gouzil as code owners August 20, 2025 08:03

zhwesky2010 reviewed Aug 20, 2025

View reviewed changes

SigureMo reviewed Aug 20, 2025

View reviewed changes

test/dygraph_to_static/test_pylayer.py Outdated Show resolved Hide resolved

LittleHeroZZZX added 4 commits August 20, 2025 11:47

temp remove docs

a25be34

Merge remote-tracking branch 'origin/develop' into feat/out_ops2

0d583ad

restore docs

2c1a8de

restore test_pylayer

1d6858d

wanghuancoder reviewed Aug 21, 2025

View reviewed changes

test/legacy_test/test_layer_norm_op.py Show resolved Hide resolved

Merge remote-tracking branch 'origin/develop' into feat/out_ops2

e375769

zhwesky2010 previously approved these changes Aug 21, 2025

View reviewed changes

Merge branch 'develop' into feat/out_ops2

7829ddf

LittleHeroZZZX dismissed zhwesky2010’s stale review via 7829ddf August 21, 2025 12:43

refine code style

6761f5b

		out (Tensor\|None, optional): The output tensor. Default: None.
		name(str\|None, optional): For details, please refer to :ref:`api_guide_Name`. Generally, no setting is required. Default: None.

[API Compatibility] Add out support for 11 APIs #74592

Are you sure you want to change the base?

[API Compatibility] Add out support for 11 APIs #74592

Conversation

LittleHeroZZZX commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Aug 13, 2025

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

SigureMo left a comment

Choose a reason for hiding this comment

Uh oh!

SigureMo Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

LittleHeroZZZX Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

SigureMo Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LittleHeroZZZX commented Aug 14, 2025

Uh oh!

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

LittleHeroZZZX commented Aug 14, 2025

Uh oh!

zhwesky2010 Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

LittleHeroZZZX Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

zhwesky2010 Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

LittleHeroZZZX Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LittleHeroZZZX commented Aug 20, 2025

Uh oh!

Uh oh!

LittleHeroZZZX commented Aug 21, 2025

Uh oh!

LittleHeroZZZX commented Aug 21, 2025

Uh oh!

LittleHeroZZZX commented Aug 21, 2025

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

LittleHeroZZZX commented Aug 21, 2025

Uh oh!

LittleHeroZZZX commented Aug 21, 2025

Uh oh!

Uh oh!

LittleHeroZZZX commented Aug 13, 2025 •

edited

Loading

SigureMo Aug 13, 2025 •

edited

Loading

codecov-commenter commented Aug 14, 2025 •

edited

Loading