Skip to content

chore: Remove 'spec' prefix from pango type and func names #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

michalbil
Copy link
Contributor

@michalbil michalbil commented Jul 15, 2024

Description

Remove "spec"/"Spec" prefixes from type and func names generated for pango library.

Motivation and Context

The library should clearly and briefly define required types, without any reference to generator-level concepts like 'spec'. This makes it easier to understand for end users.

Additionally, this enables terraform provider generator to reuse common code, without having to follow 'spec' prefix naming convention.

How Has This Been Tested?

Generate pango, run example, run tests.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@michalbil michalbil changed the title chore: Remove 'spec' prefix from pango type names chore: Remove 'spec' prefix from pango type and func names Jul 16, 2024
Copy link
Member

@migara migara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :+1

@michalbil michalbil merged commit a98a3b6 into main Jul 17, 2024
2 checks passed
@michalbil michalbil deleted the remove-spec-prefix branch July 17, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants