Skip to content

fix: Default log level handling #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

michalbil
Copy link
Contributor

@michalbil michalbil commented Jul 24, 2024

Description

Handle cases when Client does not have Logging explicitly set, which right now results in "invalid memory address or nil pointer dereference" runtime error in setupLogging function.

Motivation and Context

Bug fix.

How Has This Been Tested?

Generate code, run pango example, run terraform sample code.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@michalbil michalbil requested review from migara and kklimonda-cl July 24, 2024 15:57
@kklimonda-cl kklimonda-cl merged commit cdcfe25 into main Jul 25, 2024
4 checks passed
@kklimonda-cl kklimonda-cl deleted the fix-default-loglevel-handling branch July 25, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants